-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: can not upgrade karmada controller manager deployment with helm upgrade #3818
fix: can not upgrade karmada controller manager deployment with helm upgrade #3818
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3818 +/- ##
==========================================
- Coverage 55.69% 55.64% -0.06%
==========================================
Files 222 226 +4
Lines 21195 21378 +183
==========================================
+ Hits 11805 11896 +91
- Misses 8763 8848 +85
- Partials 627 634 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
264ea41
to
685334f
Compare
/cc @calvin0327 |
685334f
to
cdb2ec4
Compare
done, please review @Poor12 @calvin0327 |
ce080fc
to
e3f38f9
Compare
…upgrade Signed-off-by: coderth <[email protected]>
e3f38f9
to
14bce50
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
in this issue,Error occurs when using helm upgrade karmada, here add post-upgrade in karmada-controller-manager.yaml
Which issue(s) this PR fixes:
Fixes #3813
Special notes for your reviewer:
Does this PR introduce a user-facing change?: