Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can not upgrade karmada controller manager deployment with helm upgrade #3818

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

CoderTH
Copy link
Contributor

@CoderTH CoderTH commented Jul 20, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:

in this issue,Error occurs when using helm upgrade karmada, here add post-upgrade in karmada-controller-manager.yaml

Which issue(s) this PR fixes:
Fixes #3813

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 20, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 20, 2023
@CoderTH CoderTH changed the title fix: can not upgrade karmada controller manager deployment with helm … fix: can not upgrade karmada controller manager deployment with helm upgrade Jul 20, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3818 (264ea41) into master (fb317bd) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #3818      +/-   ##
==========================================
- Coverage   55.69%   55.64%   -0.06%     
==========================================
  Files         222      226       +4     
  Lines       21195    21378     +183     
==========================================
+ Hits        11805    11896      +91     
- Misses       8763     8848      +85     
- Partials      627      634       +7     
Flag Coverage Δ
unittests 55.64% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes

@CoderTH
Copy link
Contributor Author

CoderTH commented Jul 20, 2023

image
image
image
test successful

@CoderTH CoderTH force-pushed the fix-controller-helm-upgrade branch from 264ea41 to 685334f Compare July 20, 2023 07:43
@jwcesign
Copy link
Member

/cc @calvin0327

@CoderTH CoderTH force-pushed the fix-controller-helm-upgrade branch from 685334f to cdb2ec4 Compare July 25, 2023 03:56
@CoderTH
Copy link
Contributor Author

CoderTH commented Jul 25, 2023

done, please review @Poor12 @calvin0327

@CoderTH CoderTH force-pushed the fix-controller-helm-upgrade branch 2 times, most recently from ce080fc to e3f38f9 Compare July 25, 2023 09:49
@calvin0327
Copy link

calvin0327 commented Jul 26, 2023

I agree with @Poor12 , if rollback version problem cannot be resolved, we would rather remove this hook.

I can stand the karmada-controller-manager restart a few times.

@wu0407 Do you have good idea?

@CoderTH CoderTH force-pushed the fix-controller-helm-upgrade branch from e3f38f9 to 14bce50 Compare July 26, 2023 03:59
@calvin0327
Copy link

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
@karmada-bot karmada-bot merged commit cf90ffc into karmada-io:master Jul 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't upgrade karmada controller manager deployment with Helm upgrade
7 participants