-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: add the i18nTool project for ospp 2024. #127
Conversation
It still needs to add and renovate the 'translate' part. More, some Chinese content needs to turn into English. It won't wait long time. 🫡 |
…rent languages. And all chinese contents have turn to english.
I want to add the LLM API soon. |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use pnpm, it's no need to use npm to manage dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we can delete this file
if (!configFilePath) { | ||
// Get the directory where this script is located and construct the default path to i18n.config.js | ||
const scriptDir = path.dirname(__filename); // Get the directory where i18n-tool.js is located | ||
configFilePath = path.join(scriptDir, 'i18n.config.js'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, you mean if user don't specify the config file, our cli will try to load the i18n.config.js
in the i18n-tool ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, This config in the same directory is set as the default path, if the user does not specify it by the -c parameter.
// Get the directory where this script is located and construct the default path to i18n.config.js | ||
const scriptDir = path.dirname(__filename); // Get the directory where i18n-tool.js is located | ||
configFilePath = path.join(scriptDir, 'i18n.config.js'); | ||
console.log(`No configuration file specified, using default path: ${configFilePath}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we unify all the log usage ? You provide the log
method, you use console.log
for some cases but log
for another cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My original idea is adding debug model that developer can test and find where are the errors. The idea might be childish. I will improve.
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
feature
What this PR does / why we need it:
It's the out-of-the-box i18n tool, which can i18n transforms codes under development. It also offers translation feature, adapting multiple ways of translating.
Which issue(s) this PR fixes:
Fixes #53
Special notes for your reviewer:
It still needs some enhance and fix up.
Does this PR introduce a user-facing change?:
NONE.