Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add service management #114

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

warjiang
Copy link
Contributor

@warjiang warjiang commented Sep 9, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • implement management for service
  • export rest api for frontend web-ui

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 9, 2024
@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 9, 2024
@RainbowMango
Copy link
Member

How many other resource types we are going to add? Is there a list for it?
With the list, I can see the process.

@warjiang
Copy link
Contributor Author

warjiang commented Sep 9, 2024

I list the related resource in the #76
image

Till now, we only left ingress resource under the service before the first release.

@warjiang
Copy link
Contributor Author

warjiang commented Sep 9, 2024

/assign @RainbowMango @samzong

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
@karmada-bot karmada-bot merged commit ba0fef4 into karmada-io:main Sep 10, 2024
4 checks passed
@warjiang warjiang deleted the feature/service-management branch October 23, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants