kvm clone: skips disks without sources

karmab · Apr 6, 2024 · 32f0019 · 32f0019
1 parent d81e65f
commit 32f0019
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/kvirt/providers/kvm/__init__.py b/kvirt/providers/kvm/__init__.py
@@ -2259,6 +2259,13 @@ def _xmlvolume(self, path, size, pooltype='file', backing=None, diskformat='qcow
 
     def clone(self, old, new, full=False, start=False):
         conn = self.conn
+        try:
+            conn.lookupByName(new)
+            msg = f"VM {new} already exists"
+            error(msg)
+            return {'result': 'failure', 'reason': msg}
+        except:
+            pass
         try:
             oldvm = conn.lookupByName(old)
         except:
@@ -2280,6 +2287,8 @@ def clone(self, old, new, full=False, start=False):
         for disk in list(tree.iter('disk')):
             if firstdisk or full:
                 source = disk.find('source')
+                if source is None:
+                    continue
                 oldpath = source.get('file')
                 oldvolume = self.conn.storageVolLookupByPath(oldpath)
                 pool = oldvolume.storagePoolLookupByVolume()