Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated lnprob function with logf #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jontymarshall
Copy link

I implemented the nuiscance parameter "logf" in the lnprob function within measure_extinction/utils/fit_model.py following the emcee docs here (https://emcee.readthedocs.io/en/stable/tutorials/line/). This enables the fitting to take some steps toward addressing if the error bars are underestimated. To do this I converted the existing 'self.weights' back into a numpy array of errors before summing them with the model and logf as required.

I also added "logf" to the params list as the final element to assist in propagating the new parameter through the code.

Implemented nuiscance parameter in log probability calculation.
@karllark karllark added the enhancement New feature or request label Dec 3, 2024
@karllark
Copy link
Owner

karllark commented Dec 3, 2024

Thanks for this PR. Need to think/evaluate what adding this would do overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants