Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add niriss mocking #126

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Add niriss mocking #126

merged 2 commits into from
Nov 6, 2024

Conversation

karllark
Copy link
Owner

@karllark karllark commented Nov 6, 2024

No description provided.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 20 lines in your changes missing coverage. Please review.

Project coverage is 43.18%. Comparing base (819b545) to head (80fb6c9).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
...easure_extinction/utils/make_obsdata_from_model.py 5.55% 17 Missing ⚠️
measure_extinction/merge_obsspec.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   41.04%   43.18%   +2.14%     
==========================================
  Files          21       22       +1     
  Lines        2863     3830     +967     
==========================================
+ Hits         1175     1654     +479     
- Misses       1688     2176     +488     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karllark karllark merged commit 14d38b4 into master Nov 6, 2024
26 of 29 checks passed
@karllark karllark deleted the add_niriss branch November 6, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant