Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spectral wavelength for relative "band" #125

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

karllark
Copy link
Owner

@karllark karllark commented Oct 3, 2024

When one has optical spectroscopy, it is better to use 0.55 micron as the relative "band" for the elx measurement. This PR enables using a spectral wavelength instead of a photometric band.

@karllark karllark added the enhancement New feature or request label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 54.83871% with 14 lines in your changes missing coverage. Please review.

Project coverage is 39.65%. Comparing base (e79245f) to head (bbd0b84).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
measure_extinction/extdata.py 54.83% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   39.67%   39.65%   -0.03%     
==========================================
  Files          22       22              
  Lines        3017     3039      +22     
==========================================
+ Hits         1197     1205       +8     
- Misses       1820     1834      +14     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karllark karllark merged commit 62fbaff into master Nov 27, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant