Add rebin mod post fit fix #116
Conversation
|
Not yet... did not mean to push a change to my home dir path in utils/helpers.py. Will revert temporarily. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
==========================================
- Coverage 41.07% 40.82% -0.26%
==========================================
Files 21 21
Lines 2858 2878 +20
==========================================
+ Hits 1174 1175 +1
- Misses 1684 1703 +19 ☔ View full report in Codecov by Sentry. |
|
@karllark, I am not given the option to formally request a review (but can convert to draft?), so feel free to take a look and see what you think. |
| new_uncs[j] = np.sum(full_flux_uncs[cspec][k][indxs]) / len(indxs) | ||
|
|
||
| # assign rebinned flux values to flux arrays | ||
| self.waves["STIS"] = new_waves |
There was a problem hiding this comment.
Shouldn't this be cspec instead of "STIS"?
| full_fluxes = {} | ||
| full_flux_uncs = {} | ||
| full_fluxes[cspec] = np.zeros( | ||
| (self.n_models, len(moddata.data[cspec].fluxes)) | ||
| ) | ||
| full_flux_uncs[cspec] = np.zeros( | ||
| (self.n_models, len(moddata.data[cspec].fluxes)) | ||
| ) |
There was a problem hiding this comment.
This seems like it is in the wrong place. Will this not re-initialize these variables for every value of k? This does not seem like the correct behavior.
There was a problem hiding this comment.
Almost feel that the self.n_models can be removed and just do full_fluxes and full_flux_uncs for each model. There is no need to have information about a previous model for rebinning, right?
| if self.temps_width2 == 0: | ||
| self.temps_width2 == 1.0 |
There was a problem hiding this comment.
Is there a reason these 2 lines (and the other two sets of two lines below) are removed? These are needed in case the width in a model parameter is zero (e.g., input a list of files w/o any variation in that parameter).
Adds the option to rebin the model spectra to a given resolution over a WL range.
Rebinning structure is slightly different than in stardata.py but method is identical.