Add rebinning to a constant resolution for spectra and extinction data #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karllark
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 46.52% 47.56% +1.03%
==========================================
Files 19 19
Lines 2577 2670 +93
==========================================
+ Hits 1199 1270 +71
- Misses 1378 1400 +22 ☔ View full report in Codecov by Sentry. |
mdecleir
reviewed
Jan 20, 2022
mdecleir
reviewed
Feb 1, 2022
|
Ok to merge now? |
mdecleir
reviewed
Mar 2, 2022
measure_extinction/stardata.py
Outdated
| @@ -816,7 +816,7 @@ def rebin_constres(self, waverange, resolution): | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| waverange : [float, float] | |||
| waverange : 2 element array of atropy Quantities | |||
There was a problem hiding this comment.
Suggested change
| waverange : 2 element array of atropy Quantities | |
| waverange : 2 element array of Astropy Quantities |
mdecleir
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option to rebin to a specified constant spectral resolution for spectra and spectral extinction curves. Documentation for the basic classes and capabilities including the rebinning included.
As part of the testing of the rebinning, some changes to the plotting scripts were made. One change was to remove the forcing of all filenames to be lower case allowing for a wider range of filenames to be used. Another was to switch from using the filenames to using the saved names of the reddened and comparison stars in the extinction FITS files.
Finally, the wavenum capability added previously in PR #81 did not fully work with the plotting scripts. Updates were made to more fully support plotting versus 1/lambda. The missing plotting capabilities were revealed during the rebin testing.
Fixes a few minor bugs found during this work.