fix: #56 add background colour to icon #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a transparent background the icon becomes invisible when the browser is using a dark colour theme. This change gives it a background colour for visibility. FYI the shade of green is from the shades of green used in https://orgmode.org/
karlicoss
added a commit
that referenced
this pull request
Apr 23, 2024
|
Hey, sorry just got time to take a look at it! Thanks for the icon! I wouldn't want to change the default icon, but I implemented theme detection and it should set your icon if it's using dark mode! |
karlicoss
added a commit
that referenced
this pull request
Apr 23, 2024
karlicoss
added a commit
that referenced
this pull request
Apr 24, 2024
(forgot to commit previously) see #57
karlicoss
added a commit
that referenced
this pull request
Apr 24, 2024
(forgot to commit previously) see #57
|
looks like chrome extension was released! I have to do a bit more work for the firefox one due to manifest v3 migration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a transparent background the icon becomes invisible when the browser is using a dark colour theme. This change gives it a background colour for visibility.
FYI the shade of green is from the shades of green used in https://orgmode.org