Multi-user shoutcast and removed corner images from web interface #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheTaLlesT
force-pushed
the
master
branch
2 times, most recently
from
2e3918a
to
4a5eefe
Compare
karlheyes
added a commit
that referenced
this pull request
Jul 4, 2023
…242 Use the css aspects to use the in-built browser use which allows us to avoid the extra requests to get the images. The other part of the pull is the multi-user shoutcast compatible handling. That already exists using a similar type of layout but whether there is something different in the implementation will need to assessed. The web page changes though are fine. karl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed corner images from web interface and replaced with CSS to keep original appearance.
Added hyphen, period, underscore, and tilde as safe URL characters (see rfc3986).
Adds the ability for shoutcast sources to define a login user and mount point by using the patterns below.
If a mount point is not defined, it uses the configuration file defined mount.
If a user is not defined, it uses the default 'source' user.
This allows several shoutcast sources to log in at once using different mount points.
The flexibility in the login patterns is to optionally allow users to define the mountpoint in the non-obfuscated text boxes of their source client.
Hopefully my force push doesn't hurt anything. I'm still learning how to use git and I didn't know how to merge upstream changes. I think its right now.