-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement flags for synchronizing the image list when changing the working directory #792
base: master
Are you sure you want to change the base?
Commits on Mar 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a652fb0 - Browse repository at this point
Copy the full SHA a652fb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b8b9f4 - Browse repository at this point
Copy the full SHA 0b8b9f4View commit details
Commits on Mar 19, 2024
-
Refactor :scroll left/right --open-selected
Instead of having the working directory handler directly load the directory, we now defer this to the LibraryModel. This way, the model can decide if the path selected in the new directory is an image. If yes, load it - with this image focused. Thus, we don't end up jumping positions like previously, when we enter a directory that: * Has images * Has an image in the stored position Where: 1) We would load the directory into the library => paths visible in library 2) We would load the stored position => new path selected 3) We would load all images into the image filelist 4) We would open the first image 5) The library would select the first image => jump to new path which is not desirable
Configuration menu - View commit details
-
Copy full SHA for 46dd68b - Browse repository at this point
Copy the full SHA 46dd68bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7422de3 - Browse repository at this point
Copy the full SHA 7422de3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aa7e95 - Browse repository at this point
Copy the full SHA 5aa7e95View commit details -
Extend behaviour of :scroll left/right --autoload
1) The stored path is an image => load images and select this one 2) There are images in the directory => load images and select the first image, overriding any stored directory 3) There are no images in the new directory => clear images This comes very close to the preferred behaviour in #132, except for the async part which we are omitting, in favour of the *optional* --open-selected flag.
Configuration menu - View commit details
-
Copy full SHA for dff7cdc - Browse repository at this point
Copy the full SHA dff7cdcView commit details -
Add --open-images flag to :open command
This emulates the behaviour of :scroll left/right --open-selected by directly setting autoload in the library.
Configuration menu - View commit details
-
Copy full SHA for 8e7d35c - Browse repository at this point
Copy the full SHA 8e7d35cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98d403e - Browse repository at this point
Copy the full SHA 98d403eView commit details -
Add test for clearing images after :scroll left
The image filelist should be empty when running :scroll left --open-selected and entering a directory without any images.
Configuration menu - View commit details
-
Copy full SHA for 65d8266 - Browse repository at this point
Copy the full SHA 65d8266View commit details -
Update imutils.filelist clear behaviour
React to the emitted signal, instead of exclusively emitting it.
Configuration menu - View commit details
-
Copy full SHA for c89ffce - Browse repository at this point
Copy the full SHA c89ffceView commit details