Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #9

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Refactoring #9

wants to merge 6 commits into from

Commits on Mar 2, 2016

  1. renamed MATCHING enum to KSPasswordFieldMatching 

    Using such unscoped names makes it possible to have naming conflicts
between the library and the rest of the app. They also look very out of
place in Swift code.
    @mackuba
    mackuba committed Mar 2, 2016
    Configuration menu
    Copy the full SHA
    f386844 View commit details
    Browse the repository at this point in the history

  2. moved ivars and protocol info to implementation file 

    Neither of these needs to be public information.
    @mackuba
    mackuba committed Mar 2, 2016
    Configuration menu
    Copy the full SHA
    9c74f85 View commit details
    Browse the repository at this point in the history

  3. renamed notification and exposed in the header file

    @mackuba
    mackuba committed Mar 2, 2016
    Configuration menu
    Copy the full SHA
    201c60c View commit details
    Browse the repository at this point in the history

  4. renamed PasswordMeter enum & values 

    Using such unscoped names makes it possible to have naming conflicts
between the library and the rest of the app.
    @mackuba
    mackuba committed Mar 2, 2016
    Configuration menu
    Copy the full SHA
    e9461e5 View commit details
    Browse the repository at this point in the history

  5. made whitespace usage more consistent and standard

    @mackuba
    mackuba committed Mar 2, 2016
    Configuration menu
    Copy the full SHA
    24f78ad View commit details
    Browse the repository at this point in the history

  6. marked some properties as IB-inspectable

    @mackuba
    mackuba committed Mar 2, 2016
    Configuration menu
    Copy the full SHA
    ce2bb8f View commit details
    Browse the repository at this point in the history