Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save button overflow issue in create/edit row sheets 🐛 #95 #103

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

kareemmahlees
Copy link
Owner

closes #95

@kareemmahlees kareemmahlees added bug Something isn't working fix A PR is fixing a bug labels Sep 14, 2024
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "change scroll area position to fix save button overflow issue 🐛 #95". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@kareemmahlees kareemmahlees changed the title change scroll area position to fix save button overflow issue 🐛 #95 sdfsfsdchange scroll area position to fix save button overflow issue 🐛 #95 Sep 14, 2024
@kareemmahlees kareemmahlees changed the title sdfsfsdchange scroll area position to fix save button overflow issue 🐛 #95 fix: save button overflow issue in create/edit row sheets 🐛 #95 Sep 14, 2024
@kareemmahlees kareemmahlees merged commit 73cddb1 into master Sep 14, 2024
11 checks passed
@kareemmahlees kareemmahlees deleted the fix/save-button-overflow branch September 14, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix A PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Save button overflows beyond the lower edge of the screen
1 participant