Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to MetaX #6

Merged
merged 20 commits into from
Feb 5, 2024
Merged

Migrating to MetaX #6

merged 20 commits into from
Feb 5, 2024

Conversation

kareemmahlees
Copy link
Owner

@kareemmahlees kareemmahlees commented Feb 4, 2024

Features

MySQL-Meta is now MetaX with support for SQLite and PostgreSQL and the following added:

  • REST endpoints for SQLite
  • REST endpoints for Postgres
  • GraphQL resolvers for SQLite
  • GraphQL resolvers for MySQL

Refactoring

All the response or request bodies are now moved into a separate models package.

Modifications to Testing

We now use TestContainers to setup containers for the three database providers during testing

Copy link

gitguardian bot commented Feb 4, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9462643 Triggered Generic Password 5caedeb utils/testHelpers.go View secret
9462643 Triggered Generic Password 2745782 utils/testHelpers.go View secret
9462643 Triggered Generic Password 2745782 utils/testHelpers.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 159 lines in your changes are missing coverage. Please review.

Comparison is base (703105b) 72.17% compared to head (2745782) 59.08%.

❗ Current head 2745782 differs from pull request most recent head 3a2189a. Consider uploading reports for the commit 3a2189a to get more accurate results

Files Patch % Lines
internal/server.go 0.00% 42 Missing ⚠️
internal/rest/tableRoutes.go 45.33% 28 Missing and 13 partials ⚠️
utils/testHelpers.go 47.76% 30 Missing and 5 partials ⚠️
lib/errors.go 0.00% 20 Missing ⚠️
internal/rest/databaseRoutes.go 65.51% 7 Missing and 3 partials ⚠️
internal/db/database.go 82.50% 5 Missing and 2 partials ⚠️
internal/db.go 57.14% 2 Missing and 1 partial ⚠️
utils/handlers.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
- Coverage   72.17%   59.08%   -13.09%     
===========================================
  Files          13       13               
  Lines         327      523      +196     
===========================================
+ Hits          236      309       +73     
- Misses         64      173      +109     
- Partials       27       41       +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kareemmahlees kareemmahlees merged commit a222191 into master Feb 5, 2024
1 of 2 checks passed
@kareemmahlees kareemmahlees deleted the meta-x branch February 5, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant