move setRenderer for ssr to vdom.nim

[bung87]

No description provided.

[bung87]

move to bigger patch #208

[Araq]

What is the goal of this PR? setRenderer does not belong to vdom.nim

[bung87]

karax.nim import js target only module, that will cause compile time error, so I move to vdom.nim

[Araq]

Can you move it into its own module instead?

[bung87]

so user need import extro module, what's the module name ? I have no idea.

[Araq]

I just realized that I don't understand the purpose of setRenderer so I cannot give you good advice to where it belongs.

[bung87]

it renders to c backend and generate html to a relative path.

[Araq]

Then it should be renamed to something else and vdom can contain it.

[bung87]

so what it should be named ?

[Araq]

proc renderToFile*(file: string; renderer: proc (): VNode)

No command line handling required.

[geotre]

@bung87 do you want to implement the proposed name change (and deprecate the old one) or should we close this PR?

[geotre]

I'm going to close this for now, but please let me know if you want to reopen it @bung87