Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo publishing #4

Merged
merged 11 commits into from
Oct 17, 2024
Merged

Add repo publishing #4

merged 11 commits into from
Oct 17, 2024

Conversation

jinnatar
Copy link
Collaborator

@jinnatar jinnatar commented Oct 12, 2024

This one, when finalized, will make it either go live or boom.

Related: kanidm/kanidm#3078

TODO:

  • Try out the deploy key warcrime: Would need to build on a different action, or see if FR: Using a deploy key instead of OAuth token crazy-max/ghaction-github-pages#230 goes anywhere.
  • Test everything
  • Rewrite this TODO into an actual deployment plan
  • Flip all the TODO values to real ones
  • Get the parent PR finalized
  • Yeet this into main.
  • If successful, come back and enable import & extend in the aptly action.

needs: create-repo
runs-on: ubuntu-24.04
# TODO: Enable the conditional once PR testing is done
#if: github.ref == 'refs/heads/main'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could move this down to the "publish to PPA" step so it runs all the other bits regardless.

Copy link
Member

@yaleman yaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit but otherwise 🥳

.github/workflows/create-apt-repo.yml Show resolved Hide resolved
@yaleman
Copy link
Member

yaleman commented Oct 14, 2024

DEPLOY_PAT has been added

@jinnatar
Copy link
Collaborator Author

Latest run seems to be as expected: https://github.com/kanidm/kanidm_ppa_automation/actions/runs/11318699131?pr=4
.. i.e. builds succeed now for nightly, but fail for stable. I've created an example backport PR at kanidm/kanidm#3108 which should make stable buildable without affecting the v1.3.3 tag.

But I could also just rip out the stable category now and launch with only nightly? I don't think it would kill the upgrade path for anyone.

@jinnatar jinnatar marked this pull request as ready for review October 15, 2024 12:31
@jinnatar jinnatar changed the title WIP: Publishing Add repo publishing Oct 15, 2024
@jinnatar
Copy link
Collaborator Author

Run is looking good so lets see what happens!

@jinnatar jinnatar merged commit c1aa084 into kanidm:main Oct 17, 2024
12 checks passed
@jinnatar jinnatar deleted the publishing branch October 17, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants