-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abartlet tombstone reanimation wip #3
base: master
Are you sure you want to change the base?
Commits on Dec 7, 2014
-
lib: Simplify load_case_tables_library()
We don't really need a talloc context here Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e60433e - Browse repository at this point
Copy the full SHA e60433eView commit details -
s3: smbd: Fix *allocate* calls to follow POSIX error return convention.
vfswrap_fallocate() is broken in that it can call posix_fallocate() which returns an int error (and doesn't set errno) but can also call Linux fallocate() which returns -1 and sets errno. Standardize on the -1,errno convention. Reported by Jones <[email protected]> who provided the initial patch. This patch tested and confirmed working by him as well. https://bugzilla.samba.org/show_bug.cgi?id=10982 Signed-off-by: Jeremy Allison <[email protected]> Reviewed-by: David Disseldorp <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c9235de - Browse repository at this point
Copy the full SHA c9235deView commit details -
s3: smbd: Fix *allocate* calls to follow POSIX error return convention.
Fix vfs_allocate_file_space(), vfs_slow_fallocate(), vfs_fill_sparse() to follow the -1,errno convention for errors. Standardize on the -1,errno convention. Reported by Jones <[email protected]> who provided the initial patch. This patch tested and confirmed working by him as well. https://bugzilla.samba.org/show_bug.cgi?id=10982 Signed-off-by: Jeremy Allison <[email protected]> Reviewed-by: David Disseldorp <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cc1f91c - Browse repository at this point
Copy the full SHA cc1f91cView commit details
Commits on Dec 8, 2014
-
s3: modules: Fix *allocate* calls to follow POSIX error return conven…
…tion. Fix up the ceph, fruit, time_audit and streams_xattr modules to follow the -1,errno convention for errors. Reported by Jones <[email protected]> who provided the initial patch. This patch tested and confirmed working by him as well. Signed-off-by: Jeremy Allison <[email protected]> Reviewed-by: David Disseldorp <[email protected]> Autobuild-User(master): Jeremy Allison <[email protected]> Autobuild-Date(master): Mon Dec 8 02:59:43 CET 2014 on sn-devel-104
Configuration menu - View commit details
-
Copy full SHA for 2845e1c - Browse repository at this point
Copy the full SHA 2845e1cView commit details -
s4-ldap: Pass on-wire transmitted control down the chain
Change-Id: Ic3a117f74e8a67c45584fdb520d92e4f0cb01c5e Signed-off-by: Kamen Mazdrashki <[email protected]> Reviewed-by: Andrew Bartlett <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6214dbd - Browse repository at this point
Copy the full SHA 6214dbdView commit details -
s4-tests/env_loadparm: Throw KeyError in case SMB_CONF_PATH
A bit more specific for the caller to "know" that env key is missing Change-Id: I4d4c2121af868d79f46f865f420336222bc67347 Signed-off-by: Kamen Mazdrashki <[email protected]> Reviewed-by: Jelmer Vernooij <[email protected]> Autobuild-User(master): Kamen Mazdrashki <[email protected]> Autobuild-Date(master): Mon Dec 8 05:27:34 CET 2014 on sn-devel-104
Configuration menu - View commit details
-
Copy full SHA for 29732b0 - Browse repository at this point
Copy the full SHA 29732b0View commit details -
socket_wrapper: Add missing prototype check for eventfd.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10965 Newer glibc versions use and unsinged integer for the count instead of an integer. Signed-off-by: Andreas Schneider <[email protected]> Reviewed-by: Stefan Metzmacher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 78e8baf - Browse repository at this point
Copy the full SHA 78e8bafView commit details -
smbd: Add missing include for iov_buflen().
Signed-off-by: Andreas Schneider <[email protected]> Reviewed-by: Stefan Metzmacher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 266323d - Browse repository at this point
Copy the full SHA 266323dView commit details -
vfs: Add missing include for sys_pread() in cacheprime module.
Signed-off-by: Andreas Schneider <[email protected]> Reviewed-by: Stefan Metzmacher <[email protected]> Autobuild-User(master): Stefan Metzmacher <[email protected]> Autobuild-Date(master): Mon Dec 8 16:54:51 CET 2014 on sn-devel-104
Configuration menu - View commit details
-
Copy full SHA for 4acf171 - Browse repository at this point
Copy the full SHA 4acf171View commit details
Commits on Dec 9, 2014
-
s3:locking: pass servicename_new to leases_db_rename()
Signed-off-by: Jeremy Allison <[email protected]> Reviewed-by: Stefan Metzmacher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2cd9a5c - Browse repository at this point
Copy the full SHA 2cd9a5cView commit details -
s3:locking: prepare the data model for leases_db to cope with dynamic…
… path renames. interface leases_db { typedef [public] struct { GUID client_guid; smb2_lease_key lease_key; } leases_db_key; typedef [public] struct { file_id id; [string,charset(UTF8)] char *servicepath; [string,charset(UTF8)] char *base_name; [string,charset(UTF8)] char *stream_name; } leases_db_file; typedef [public] struct { uint32 num_files; [size_is(num_files)] leases_db_file files[]; } leases_db_value; } As designed by metze. Signed-off-by: Jeremy Allison <[email protected]> Reviewed-by: Stefan Metzmacher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5661198 - Browse repository at this point
Copy the full SHA 5661198View commit details -
s3:locking: Add new utility function leases_db_copy_file_ids()
Will be used by lease db parsers. Signed-off-by: Jeremy Allison <[email protected]> Reviewed-by: Stefan Metzmacher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b3b878e - Browse repository at this point
Copy the full SHA b3b878eView commit details -
s3:locking: pass down servicepath to leases_db_add()
Signed-off-by: Jeremy Allison <[email protected]> Reviewed-by: Stefan Metzmacher <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 708f87b - Browse repository at this point
Copy the full SHA 708f87bView commit details -
s3:locking: Change the data model for leases_db to cope with dynamic …
…path renames. interface leases_db { typedef [public] struct { GUID client_guid; smb2_lease_key lease_key; } leases_db_key; typedef [public] struct { file_id id; [string,charset(UTF8)] char *servicepath; [string,charset(UTF8)] char *base_name; [string,charset(UTF8)] char *stream_name; } leases_db_file; typedef [public] struct { uint32 num_files; [size_is(num_files)] leases_db_file files[]; } leases_db_value; } As designed by metze. Signed-off-by: Jeremy Allison <[email protected]> Reviewed-by: Stefan Metzmacher <[email protected]> Autobuild-User(master): Jeremy Allison <[email protected]> Autobuild-Date(master): Tue Dec 9 03:44:04 CET 2014 on sn-devel-104
Configuration menu - View commit details
-
Copy full SHA for 5ebb190 - Browse repository at this point
Copy the full SHA 5ebb190View commit details -
Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4debc30 - Browse repository at this point
Copy the full SHA 4debc30View commit details -
Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e2ee1a4 - Browse repository at this point
Copy the full SHA e2ee1a4View commit details -
messaging3: Avoid self-send complexity
With the notify code I've hit another case where self-sends caused a problem. This time messages were lost because we tried to do multiple dispatch_rec calls from within a single inotify callback. Only the first one was being taken care of, the others did not find receivers. This patch makes self-sends go through the kernel as well, the kernel queues everything nicely for us. With dgram messaging this should be pretty fast. If it turns out to be a performance problem, we can solve it later by doing proper queueing in user space. We need to completely decouple any processing from callbacks. Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3a6a6f1 - Browse repository at this point
Copy the full SHA 3a6a6f1View commit details -
This makes iov_buf independent of talloc Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d775c38 - Browse repository at this point
Copy the full SHA d775c38View commit details -
Now that iov_buf does not pull in talloc we can use it Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dc38f64 - Browse repository at this point
Copy the full SHA dc38f64View commit details -
smbd: Move lp_parm_bool out of notify_inotify.c
Notifyd should be as independent of Samba infrastructure as possible, and it will call notify_inotify Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8a49485 - Browse repository at this point
Copy the full SHA 8a49485View commit details -
notify_inotify: Simplify filter_match
Early returns make code simpler Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 18b6822 - Browse repository at this point
Copy the full SHA 18b6822View commit details -
notify_inotify: Add a NULL check
Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 608774d - Browse repository at this point
Copy the full SHA 608774dView commit details -
notify_inotify: Make inotify_setup return 0/errno
This gets rid of one NT_STATUS_HAVE_NO_MEMORY with its implicit return; :-) Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for eb10a36 - Browse repository at this point
Copy the full SHA eb10a36View commit details -
notify_inotify: Slightly simplify inotify_watch
tallocing first avoids having to call inotify_rm_watch This even fixes a real error: We share inotifies between different instances, so the rm_watch in the error paths destroys other legitimate watches Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 01a1678 - Browse repository at this point
Copy the full SHA 01a1678View commit details -
notify_inotify: Slightly simplify watch_destructor
Another case of an early return Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9b47445 - Browse repository at this point
Copy the full SHA 9b47445View commit details -
notify_inotify: Make inotify_watch return 0/errno
More like a cleanup, but I want to use inotify_watch in notifyd that I would like to keep as light as possible Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f530d6d - Browse repository at this point
Copy the full SHA f530d6dView commit details -
notify: Add "dir" to notify_event
"notify_event" only reports names relative to some path that is only implicitly known via "private_data". Right now "private_data" is the fsp of the directory holding this notify. I want to use inotify_watch in a notify-daemon that does not have a fsp available and has more problems getting the path right out of "private_data". notify_inotify has the directory under which the event happened available, so make it known to the callback. Right now no caller uses it yet. Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for de4a1c9 - Browse repository at this point
Copy the full SHA de4a1c9View commit details -
notify_inotify: inotify_watch now takes a mem_ctx
This will make it easier to integrate into proper memory hierarchies. Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a5a5326 - Browse repository at this point
Copy the full SHA a5a5326View commit details -
smbd: Compile notify_inotify only if available
Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 658ffb1 - Browse repository at this point
Copy the full SHA 658ffb1View commit details -
notify_inotify: Simplify inotify_dispatch
Normally, I'm trying to simplify things with early returns. But in this case I think the reverse makes the if-condition easier to understand Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]> Autobuild-User(master): Jeremy Allison <[email protected]> Autobuild-Date(master): Tue Dec 9 06:37:24 CET 2014 on sn-devel-104
Configuration menu - View commit details
-
Copy full SHA for 9bb0728 - Browse repository at this point
Copy the full SHA 9bb0728View commit details -
torture: Fix raw.open.chained-ntcreatex
sizeof(buf) is 5. On FreeBSD10/clang this overwrites "ret". Not good. Same as 5747507 Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]> Autobuild-User(master): Jeremy Allison <[email protected]> Autobuild-Date(master): Tue Dec 9 19:43:31 CET 2014 on sn-devel-104
Configuration menu - View commit details
-
Copy full SHA for 8c56989 - Browse repository at this point
Copy the full SHA 8c56989View commit details
Commits on Dec 10, 2014
-
vfs_glusterfs: In vfs_gluster_sys_acl_get_file/fd, reduce the number …
…of getxattr calls. Signed-off-by: Poornima G <[email protected]> Reviewed-by: Ira Cooper <[email protected]> Reviewed-by: Guenther Deschner <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a4fa9ca - Browse repository at this point
Copy the full SHA a4fa9caView commit details -
vfs_glusterfs: Remember the connect path too for reopening.
As Samba allows us to share subdirs, lets re-use preopened connections to glusterfs only if they are for same volume AND same connectpath. Signed-off-by: raghavendra talur <[email protected]> Reviewed-by: Guenther Deschner <[email protected]> Reviewed-by: Michael Adam <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2fb4317 - Browse repository at this point
Copy the full SHA 2fb4317View commit details -
vfs_glusterfs: Set connectpath as snapdir-entry-path.
snapview client in gluster would require connectpath in order add snapdir entry to readdir result. Signed-off-by: raghavendra talur <[email protected]> Reviewed-by: Guenther Deschner <[email protected]> Reviewed-by: Michael Adam <[email protected]> Autobuild-User(master): Günther Deschner <[email protected]> Autobuild-Date(master): Wed Dec 10 16:38:27 CET 2014 on sn-devel-104
Configuration menu - View commit details
-
Copy full SHA for a12ae81 - Browse repository at this point
Copy the full SHA a12ae81View commit details
Commits on Dec 11, 2014
-
netapi: Move DC check to NetJoinDomain() where it is needed.
This partially reverts 15f6e27. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10891 Signed-off-by: Andrew Bartlett <[email protected]> Reviewed-by: Garming Sam <[email protected]> Reviewed-by: Andreas Schneider <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b299409 - Browse repository at this point
Copy the full SHA b299409View commit details -
selftest: Add 'net dom join' test which fails cause we are a DC
Signed-off-by: Andreas Schneider <[email protected]> Reviewed-by: Guenther Deschner <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6d6c673 - Browse repository at this point
Copy the full SHA 6d6c673View commit details -
auth: Allow domain join to itself when we are a PDC
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10891 Signed-off-by: Andrew Bartlett <[email protected]> Reviewed-by: Garming Sam <[email protected]> Reviewed-by: Andreas Schneider <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c3b5f9c - Browse repository at this point
Copy the full SHA c3b5f9cView commit details -
libsmb: Allow change of BDC trust account password
This account is otherwise just like the workstation trust acocunt, so use that code. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10891 Pair-programmed-with: Garming Sam <[email protected]> Signed-off-by: Andrew Bartlett <[email protected]> Reviewed-by: Andreas Schneider <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e6ec265 - Browse repository at this point
Copy the full SHA e6ec265View commit details -
selftest: Add test for joining a Samba classic DC as a BDC
This does not join the DC itself, so as not to pertrub the test environment mid-run, but does confirm that the join works and the password can be changed. Pair-programmed-with: Garming Sam <[email protected]> Signed-off-by: Andrew Bartlett <[email protected]> Reviewed-by: Andreas Schneider <[email protected]> Autobuild-User(master): Andreas Schneider <[email protected]> Autobuild-Date(master): Thu Dec 11 21:40:27 CET 2014 on sn-devel-104
Configuration menu - View commit details
-
Copy full SHA for 0da3ab9 - Browse repository at this point
Copy the full SHA 0da3ab9View commit details
Commits on Dec 12, 2014
-
vfs_streams_xattr: add missing call to SMB_VFS_NEXT_CONNECT
Signed-off-by: Ralph Boehme <[email protected]> Rewviewed-by: Jeremy Allison <[email protected]> Autobuild-User(master): Jeremy Allison <[email protected]> Autobuild-Date(master): Fri Dec 12 02:09:24 CET 2014 on sn-devel-104
Configuration menu - View commit details
-
Copy full SHA for 3554d88 - Browse repository at this point
Copy the full SHA 3554d88View commit details -
lib/util: Fix incorrect month in timestamps
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11003 Reported-by: Youzhong Yang <[email protected]> Signed-off-by: Martin Schwenke <[email protected]> Reviewed-by: Amitay Isaacs <[email protected]> Autobuild-User(master): Amitay Isaacs <[email protected]> Autobuild-Date(master): Fri Dec 12 05:02:32 CET 2014 on sn-devel-104
Configuration menu - View commit details
-
Copy full SHA for 0d0a0f7 - Browse repository at this point
Copy the full SHA 0d0a0f7View commit details -
s4:dsdb/rootdse: expand extended dn values with the AS_SYSTEM control
Otherwise we can't find the GUID of the 'serverName' attribute as ANONYMOUS. This results in root@ub1204-161:~# ldbsearch -U% -H ldap://172.31.9.161 -b '' -s base --extended-dn serverName search error - LDAP error 1 LDAP_OPERATIONS_ERROR - <00002020: operations error at ../source4/dsdb/samdb/ldb_modules/rootdse.c:567> <> While it works as system: root@ub1204-161:~# ldbsearch -U% -H /var/lib/samba/private/sam.ldb -b '' -s base --extended-dn serverName # record 1 dn: serverName: <GUID=348c35e1-04e3-4988-a32c-32478d584551>;CN=UB1204-161,CN=Serve rs,CN=Default-First-Site-Name,CN=Sites,CN=Configuration,DC=s4xdom,DC=base # returned 1 records # 1 entries # 0 referrals Bug: https://bugzilla.samba.org/show_bug.cgi?id=10949 Signed-off-by: Stefan Metzmacher <[email protected]> Reviewed-by: Guenther Deschner <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a6ecef4 - Browse repository at this point
Copy the full SHA a6ecef4View commit details -
testprogs/test_ldb: check rootdse search with extended-dn control
Verifies BUG: https://bugzilla.samba.org/show_bug.cgi?id=10949 Signed-off-by: Stefan Metzmacher <[email protected]> Reviewed-by: Guenther Deschner <[email protected]> Autobuild-User(master): Günther Deschner <[email protected]> Autobuild-Date(master): Fri Dec 12 20:15:46 CET 2014 on sn-devel-104
Configuration menu - View commit details
-
Copy full SHA for 7e81fe2 - Browse repository at this point
Copy the full SHA 7e81fe2View commit details -
libsmb: Fix removing invalid samlogon cache entries
Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7c73946 - Browse repository at this point
Copy the full SHA 7c73946View commit details -
libsmb: Only print decoded netsamlogon cache entries
Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8a56911 - Browse repository at this point
Copy the full SHA 8a56911View commit details -
libsmb: Simplify netsamlogon_cache_get
Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 81f99bd - Browse repository at this point
Copy the full SHA 81f99bdView commit details -
s3:smb2_server: allow reauthentication without signing
If signing is not required we should not require it for reauthentication. Windows clients would otherwise fail to reauthenticate. Bug: https://bugzilla.samba.org/show_bug.cgi?id=10958 Signed-off-by: Stefan Metzmacher <[email protected]> Reviewed-by: Jeremy Allison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3820196 - Browse repository at this point
Copy the full SHA 3820196View commit details -
libcli/smb: only force signing of smb2 session setups when binding a …
…new session Bug: https://bugzilla.samba.org/show_bug.cgi?id=10958 Signed-off-by: Stefan Metzmacher <[email protected]> Reviewed-by: Jeremy Allison <[email protected]> Autobuild-User(master): Jeremy Allison <[email protected]> Autobuild-Date(master): Fri Dec 12 23:11:40 CET 2014 on sn-devel-104
Configuration menu - View commit details
-
Copy full SHA for daff0f5 - Browse repository at this point
Copy the full SHA daff0f5View commit details
Commits on Dec 15, 2014
-
s4-dsdb-tests: Some tests for deleted objects undelete operation
Based on MS-ADTS 3.1.1.5.3.7.2 Signed-off-by: Nadezhda Ivanova <[email protected]> Change-Id: I650b315601fce574f9302435f812d1dd4b177e68
Configuration menu - View commit details
-
Copy full SHA for 1325078 - Browse repository at this point
Copy the full SHA 1325078View commit details -
s4-dsdb: Initial implementation for Tombstone reanimation module
At the moment it works for basic scenario: - add user - delete user - restore deleted user TODO: - security checks - flags verification - cross-NC checks - asynchronous implementation (may not be needed, but anyway) Change-Id: If396a6dfc766c224acfeb7e93ca75703e08c26e6 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d6eea17 - Browse repository at this point
Copy the full SHA d6eea17View commit details -
s4-dsdb: Insert tombstone_reanimate module in ldb modules chain after…
… objectclass Change-Id: Id9748f36f0aefe40b1894ecd2e5071e3b9c8a6d6 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for edc56c3 - Browse repository at this point
Copy the full SHA edc56c3View commit details -
s4-dsdb-tests: Remove trailing ';' in deletetest.py
Change-Id: Ic1ad6bbda55be56cbf7ae78a8ad988b8e479a40c Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3803f3b - Browse repository at this point
Copy the full SHA 3803f3bView commit details -
s4-dsdb-tests: Remove unused method get_ldap_connection()
Change-Id: Ie50f77dbba724dbd3c2822de5c2cfff41016fac6 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 856240b - Browse repository at this point
Copy the full SHA 856240bView commit details -
s4-dsdb-tests: Make unique object names to test with in deletetest
This way we can re-run the test again and again Change-Id: I29bd878b77073d94a279c38bd0afc2f0befa6f9d Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 680b63a - Browse repository at this point
Copy the full SHA 680b63aView commit details -
s4-dsdb-tests: Fix whitespace in deletetest.py
Change-Id: Ic2924b0aa9cffd29fe0c857317ccb65ba53a1c21 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7976d75 - Browse repository at this point
Copy the full SHA 7976d75View commit details -
s4-dsdb: Return error codes as windows does for Tombstone reanimation
Tested against Windows Server 2008 R2 In case we try to restore to already existing object, windows returns: LDB_ERR_ENTRY_ALREADY_EXISTS Otherwise it is: LDB_ERR_OPERATIONS_ERROR Change-Id: I6b5fea1e327416ccf5069d97a4a378a527a25f80 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8939d5c - Browse repository at this point
Copy the full SHA 8939d5cView commit details -
s4-dsdb: Initialize module context only we are to handle Tombstone re…
…quest Change-Id: I73bd2043e96907e3d1a669bdbd943ddee1df8c0a Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c0daf35 - Browse repository at this point
Copy the full SHA c0daf35View commit details -
s4-dsdb: Make most specific objectCategory for an object
This is lightweight implementation and should be used on objects with already verified objectClass attribute value - eg. valid classes, sorted properly, etc. Checkout objectclass.c module for heavy weight implementation. Change-Id: Ifa7880d26246f67e2f982496fcc6c77e6648d56f Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 57a4137 - Browse repository at this point
Copy the full SHA 57a4137View commit details -
s4-dsdb: Make use dsdb_make_object_category() for objectCategory
Change-Id: If65c54a653ad7078ca7a535b5c247db2746b5be7 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4200205 - Browse repository at this point
Copy the full SHA 4200205View commit details -
TODO SIGN-OFF s4-dsdb: Define internal dsdb control to mark Tombstone…
… reanimation requests Tombstone reanimation requries some special handling which is going to affect several modules. Most notably: - a bit different access checks in acl.c - restore certain attributes during modify requests in samldb.c Change-Id: Ief4f7dabbbdc2570924fae48c30ac9c531a701f4 TODO Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 50a1bb1 - Browse repository at this point
Copy the full SHA 50a1bb1View commit details -
s4-tests: Print out what the error is in delete_force()
Change-Id: Iaa631179dc79fa756416be8eaf8c55e3b0c1a29f Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 266695f - Browse repository at this point
Copy the full SHA 266695fView commit details -
s4-dsdb: Add documentation link for Tombstone Reanimation
Change-Id: Ib779c8b0839889371f25ad5751c9cda1a510eb54 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cc19ee2 - Browse repository at this point
Copy the full SHA cc19ee2View commit details -
s4-dsdb: Implement rename/modify requests as local for the module
The aim is for us to be able to fine tune the implementation and also add custom LDAP controls to mark all requests as being part of Reanimation procedure Change-Id: I9f1c04cd21bf032146eb2626d6495711fcadf10c Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b3477a3 - Browse repository at this point
Copy the full SHA b3477a3View commit details -
s4-dsdb: Mark request during Tombstone reanimation with custom LDAP c…
…ontrol We are going to need this so that underlying modules (acl.c) can treat those requests properly Change-Id: I6c12069aa6e7e01197dddda6c610d930d3fd9cb0 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4abb1a7 - Browse repository at this point
Copy the full SHA 4abb1a7View commit details -
TODO SIGN-OFF s4-dsdb: Tests for security checks on undelete operation
Implemented according to MS-ADTS 3.1.1.5.3.7.1. Unfortunately it appears LC is also necessary, and it is not granted by default to anyone but System and Administrator, so tests had to be done negatively TODO Signed-off-by: Nadezhda Ivanova <[email protected]> TODO: Changed to not override passed in controls in sd_utils.py Change-Id: Ic03b8fc4e222e7842ec8a9645a1bb33e7df9c438
Configuration menu - View commit details
-
Copy full SHA for b68c32c - Browse repository at this point
Copy the full SHA b68c32cView commit details -
TODO SIGN-OFF s4-dsdb: Implementation of access checks on a undelete …
…operation Special Reanimate-Tombstone access right is required, as well as most of the checks on a standard rename. Change-Id: Idae5101a5df4cd0d54fe4ab2f7e5ad7fc1c23648 TODO Signed-off-by: Nadezhda Ivanova <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 677bfff - Browse repository at this point
Copy the full SHA 677bfffView commit details -
s4-dsdb: Some minor fixes in tombstone_reanimate, to make it work wit…
…h acl Change-Id: Idad221c7ecf778fd24f6017bb4c6eacac541086a Signed-off-by: Nadezhda Ivanova <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6ff9561 - Browse repository at this point
Copy the full SHA 6ff9561View commit details -
TODO s4-dsdb-test: Implement samdb_connect_env() to rely solely on en…
…vironment this is to help me port Python tests to be more Unit test alike and remove all global handling Starting from a new test suite - tombstone_reanimation.py TODO: I don't really like this way of running things, as the environment variables may not show up in the failed command --abartlet Change-Id: I29445c42cdcafede3897c8dd1f1529222a74afc9 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c81fa23 - Browse repository at this point
Copy the full SHA c81fa23View commit details -
s4-dsdb-test: Initial implementation for Tombstone restore test suite
Change-Id: Ib35ff930b6e7cee14317328b6fe25b59eec5262c Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7abbf2a - Browse repository at this point
Copy the full SHA 7abbf2aView commit details -
s4-dsdb-test: Use case insensitive comparison for DNs in undelete test
Change-Id: I4a009bb7ed58ab857ac74a235bb5f580911f0d92 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2755a4c - Browse repository at this point
Copy the full SHA 2755a4cView commit details -
s4-dsdb-test: Restore User test case implementation
Change-Id: Iffd42b5b2fe5aef7d7381c91a6c635436b5e2e99 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4b1dfb0 - Browse repository at this point
Copy the full SHA 4b1dfb0View commit details -
s4-dsdb-test: Fix Undelete tests after subunit upgrade work
Change-Id: I4712a2a2163a57fde037511afcc1cb7bee05f12e Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d01b9a5 - Browse repository at this point
Copy the full SHA d01b9a5View commit details -
s4-dsdb-test: Restore user test case update - a bit more generic
Change-Id: Iebf78244eaca51351d09e973fdd079f167c97ba1 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5a4868a - Browse repository at this point
Copy the full SHA 5a4868aView commit details -
s4-dsdb-util: Mark attributes with ADD flag in samdb_find_or_add_attr…
…ibute() At the moment no flags are set and it works fine, since this function is solely used in samldb during ADD requests handling. Pre-setting a flag make it usefull for other modules and request handlers too Change-Id: I7e43dcbe2a8f34e3b0ec16ae2db80ef436df8bfe Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 813a7a3 - Browse repository at this point
Copy the full SHA 813a7a3View commit details -
s4-dsdb/reanimate: Implement attribute_restore function
At the moment it works for objects with objectClass user + a common case of removing isRecycled attribute Change-Id: I70b0ef0ef65c13d3def82ca53ace52a85a078a37 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dda27fc - Browse repository at this point
Copy the full SHA dda27fcView commit details -
s4-dsdb/samldb: Fix type "omputer" -> "computer"
Change-Id: Ic56c6945528b7f60becc4f0b318429f4c22c3d2e Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d8c90c6 - Browse repository at this point
Copy the full SHA d8c90c6View commit details -
s4-dsdb/samldb: Skip 'sAMAccountType' and 'primaryGroupID' during Tom…
…bstone reanimate tombstone_reanimate.c module is going to restore those attributes and it needs a way to propagate them to DB Change-Id: I36f30b33fa204fd28329eab01044a125f7a3f08e Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7dfc15b - Browse repository at this point
Copy the full SHA 7dfc15bView commit details -
s4-dsdb/reanimate: Use 'show deleted' control in modify operations too
Before committing changes, object is still deleted - isDeleted = true Change-Id: Ie1ab53dc594d1bfaf5b9e06316e7a1fc0dd4b8cb Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5c372d3 - Browse repository at this point
Copy the full SHA 5c372d3View commit details -
s4-dsdb/reanimate: Swap rename->modify operations to modify->rename s…
…equence This way it is more visible that we work on 'deleted object' during modify and also will help us to handle 'stop rename for deletec objects' propertly in future [MS-ADTS]: 3.1.1.5.3.7.3 Undelete Processing Specifics Change-Id: I9bb644e099a4a2afcb261ad22515c9c4ce4875bb Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 99bc8df - Browse repository at this point
Copy the full SHA 99bc8dfView commit details -
s4-dsdb-test: Create separate TestCase for User objects
Change-Id: I73f8cb147d6dd528428588a520826d1318a72d9f Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c2d23a7 - Browse repository at this point
Copy the full SHA c2d23a7View commit details -
s4-dsdb-test: Test tombstone reanimation for Group objects
Change-Id: Ic400c9877455e2a252c696275cab99429e1aef05 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4cd86ed - Browse repository at this point
Copy the full SHA 4cd86edView commit details -
s4-dsdb-test: More generic implementation for attribute list for clas…
…s hierarchy Change-Id: I61be257568a778de3c4dc3d18d895d81283a0531 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a7ea561 - Browse repository at this point
Copy the full SHA a7ea561View commit details -
s4-dsdb/reanimate: Group objects reanimation implementation
Change-Id: Iea92924ff6b33fa3723b104d5dfff1ce5a7a09b0 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a4cfa4b - Browse repository at this point
Copy the full SHA a4cfa4bView commit details -
s4-dsdb-test: tombstone reanimation for containers test case
At the moment tests "organizationalUnit" and "container" objects Change-Id: I1d39b97064b2b3cda22313c521e7573b14888eca Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 10097de - Browse repository at this point
Copy the full SHA 10097deView commit details -
s4-dsdb-test: remove trailing ';' in ldap.py
Change-Id: I5edc6e017b576791c1575f71a625c49ccc88fe8f Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 82e73c8 - Browse repository at this point
Copy the full SHA 82e73c8View commit details -
s4-dsdb/objectclass: remove duplicated declaration for objectclass_do…
…_add Change-Id: Ib88a45cea64fb661a41ca3b4a3df9dabf509fc6c Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7fefcc6 - Browse repository at this point
Copy the full SHA 7fefcc6View commit details -
s4-dsdb-test: Fix duplicated key in a dictionary in sam.py
Change-Id: Ie33d92bd308262d9bfda553d6d5e2cfd98f6d7b3 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b6a550d - Browse repository at this point
Copy the full SHA b6a550dView commit details -
s4-dsdb-tests: Move base tests for Tombstone reanimation in tombstone…
…_reanimation module So we have them all in one place. While moving, I have: * inherited from the base class for Tombstone reanimations * replace self.ldb with self.samdb Change-Id: Id3e4f02cc2e0877d736da812c14c91e2311203d2 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 11ef8dc - Browse repository at this point
Copy the full SHA 11ef8dcView commit details -
s4-dsdb-test/reanimate: Fix whitespaces according to PEP8
Change-Id: I7b46992c80178d40a0531b5afd71a7783068a9dd Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4f0afd9 - Browse repository at this point
Copy the full SHA 4f0afd9View commit details -
s4-dsdb/samdb: Don't relax contraint checking during rename for Delet…
…ed objects Now we have a module to handle to handle Tombstone reanimation and it is better we do all the check here as usual Change-Id: Ia5d28d64e99f7a961cfe8b9aa7cc96e4ca56192e Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 92eb987 - Browse repository at this point
Copy the full SHA 92eb987View commit details -
s4-dsdb/samldb: Relax a bit restrictions in Config partition while
restoring deleted object Change-Id: Iead460d24058b160b46cf3ddedaf4d84b844da4d Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a8aebe2 - Browse repository at this point
Copy the full SHA a8aebe2View commit details -
s4-dsdb/test: Delete any leftover objects in the beginning of Cross-N…
…C test This way we ensure that samdb is clean before we make the test Change-Id: I3c6fc94763807394e52b6df41548e9aba8b452c1 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 452c972 - Browse repository at this point
Copy the full SHA 452c972View commit details -
s4-dsdb/samldb: Don't allow rename requests on Deleted object
Windows behavior in case of renaming Deleted object is: * return ERR_NO_SUCH_OBJECT in case client is not providing SHOW_DELETED control * ERR_UNWILLING_TO_PERFORM otherwise Renaming of Deleted objects is allowed only through special Tombstone reanimation modify request Change-Id: I1eb33fc294a5de44917f6037988ea6362e6e21fc Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ca84796 - Browse repository at this point
Copy the full SHA ca84796View commit details -
s4-dsdb-test: Use common base method for restoring Deleted objects
Change-Id: I266b58ced814cf7ea3616862506df5b55f4f1d8c Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 538a712 - Browse repository at this point
Copy the full SHA 538a712View commit details -
s4-test: Fix a check for missing LoadParm argument in connect_samdb_env
Change-Id: I87b5cc4e2b26b04d99de100a91c83cbe74e3c218 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5118bea - Browse repository at this point
Copy the full SHA 5118beaView commit details -
TODO s4-test/tombstone_reanimation: Use LoadParm directly for default…
… settings No need to do anything fancy - we are going to provide user/pass anyway TODO: Why do we need this? --abartlet Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9815875 - Browse repository at this point
Copy the full SHA 9815875View commit details -
TODO s4-tests: Add tombstone_reanimation test case to s4 test suite
TODO: I don't like the $USERNAME becoming $DC_USERNAME in the test. This will just cause confusion --abartlet Change-Id: I84ff628496bfa3e0538011400328585d080f21b8 Signed-off-by: Kamen Mazdrashki <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 11abf88 - Browse repository at this point
Copy the full SHA 11abf88View commit details