Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ADA-1300): "Hide" button color scheme #51

Merged
merged 1 commit into from
Jun 23, 2024
Merged

fix(ADA-1300): "Hide" button color scheme #51

merged 1 commit into from
Jun 23, 2024

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Jun 23, 2024 •
edited by jira bot
Loading

Issue:
The button contrast is not good when the primary color is light

Solution:
Because the background is always gray text color should be white and not the primary contrast.

Solves ADA-1300

@Tzipi-kaltura Tzipi-kaltura merged commit 946586b into master Jun 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@semarche-kaltura semarche-kaltura Awaiting requested review from semarche-kaltura

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

@lianbenjamin lianbenjamin Awaiting requested review from lianbenjamin

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tzipi-kaltura @SivanA-Kaltura