Skip to content

Commit

Permalink
chore: upd readme
Browse files Browse the repository at this point in the history
  • Loading branch information
semarche-kaltura committed Feb 14, 2024
1 parent 0bd9dbd commit 2c9dc2a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ https://kaltura.github.io/playkit-js-common
- `dev` watch on file changes and build modules
- `release` bump package version and add changes from commits into CHANGELOG
- `pushTaggedRelease` push latest tag to GitHub repo
- `storybook:install` install dependencies of storybook submodule
- `storybook` run dev-server for storybook (https://storybook.js.org/docs/preact/get-started/introduction)
- `storybook:build` create static files for storybook
- `storybook:deploy` push storybook static files to GitHub pages
12 changes: 6 additions & 6 deletions src/hoc/overlay-portal/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ export class OverlayPortal extends Component<OverlayPortalProps> {
playerContainer: any = document.getElementById(this.props.targetId!) || document;

componentWillUnmount() {
// keep playkit-overlay-active class in case OverlayPortal has more children
if (this.playerContainer.querySelector(`${PORTAL_CLASS} > ${PLAYKIT_OVERLAY_CLASS}`)) {
// use timeout 0 to make sure addPlayerClass happens after removePlayerClass
setTimeout(() => {
setTimeout(() => {
if (this.playerContainer.querySelector(`${PORTAL_CLASS} > ${PLAYKIT_OVERLAY_CLASS}`)) {
// keep .playkit-overlay-active class in case OverlayPortal has playkit-ui Overlay as children
this.props.addPlayerClass!();
}, 0);
}
}
// use timeout 0 to make sure check happens after components updated
}, 0);
}

render() {
Expand Down

0 comments on commit 2c9dc2a

Please sign in to comment.