Skip to content

Commit

Permalink
fix : fixed multiples issues
Browse files Browse the repository at this point in the history
- fixed typo for the rest api deployment condition
- changed service type to clusterIP by default
- removing unnecessary double quotes in chirpstack-integration secret-config
  • Loading branch information
kalisio-nicolas committed Sep 17, 2024
1 parent bd99d03 commit cd22b15
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ stringData:
config.json: >-
{
"redisHost": "{{ .Values.config.redisHost }}",
"redisPort": "{{ .Values.config.redisPort | default "6379" }}",
"redisPort": "{{ .Values.config.redisPort | default 6379 }}",
"redisPassword": "{{ .Values.config.redisPassword }}",
"disableWrite": "{{ .Values.config.disableWrite | default "false" }}",
"cleanMongoDB": "{{ .Values.config.cleanMongoDB | default "false" }}",
"disableWrite": {{ .Values.config.disableWrite | default false }},
"cleanMongoDB": {{ .Values.config.cleanMongoDB | default false }},
"mongoUrl": "{{ .Values.config.mongoUrl }}",
"gRPCServer": "{{ .Values.config.gRPCServer | default "chirpstack:8080" }}",
"apiToken": "{{ .Values.config.apiToken }}",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
app.kubernetes.io/component: gateway-bridge
name: chirpstack-gateway-bridge
spec:
type: NodePort
type: {{ .Values.gateway_bridge.service_type }}
ports:
- name: "1700"
port: 1700
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.chirpstack.est_api_enabled }}
{{- if .Values.chirpstack.rest_api_enabled }}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down Expand Up @@ -28,7 +28,7 @@ spec:
protocol: TCP
{{ if .Values.resources.rest_api }}
resources:
{{ toYaml .Values.resources.rest_api | indent 12 }}
{{ toYaml .Values.resources.rest_api | indent 12 }}
{{ end }}
restartPolicy: Always
{{- end }}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.chirpstack.est_api_enabled }}
{{- if .Values.chirpstack.rest_api_enabled }}
apiVersion: v1
kind: Service
metadata:
Expand Down
2 changes: 1 addition & 1 deletion charts/chirpstack/templates/chirpstack-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
app.kubernetes.io/component: networkServer
name: chirpstack
spec:
type: NodePort
type: {{ if .Values.chirpstack.networkserver_node_port }}NodePort{{ else }}ClusterIP{{ end }}
ports:
- name: "8080"
port: 8080
Expand Down
2 changes: 1 addition & 1 deletion charts/chirpstack/templates/mosquitto-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
app.kubernetes.io/component: mosquitto
name: mosquitto
spec:
type: NodePort
type: {{ .Values.mosquitto.service_type }}
ports:
- name: "1883"
port: 1883
Expand Down
2 changes: 2 additions & 0 deletions charts/chirpstack/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,11 @@ chirpstack :
className : "nginx"

gateway_bridge :
service_type : "ClusterIP"
bridge_station_node_port :

mosquitto :
service_type : "ClusterIP"
node_port :


Expand Down

0 comments on commit cd22b15

Please sign in to comment.