Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useRouteMatch and useRouteMatchData #15

Open
wants to merge 2 commits into
base: split-location-and-match-context
Choose a base branch
from
Open

Remove useRouteMatch and useRouteMatchData #15

wants to merge 2 commits into from

Conversation

EECOLOR
Copy link
Member

@EECOLOR EECOLOR commented Dec 28, 2023

These functions are not used very often. On top of that they promote hard to understand code. Matching on routes somewhere in a parent could change behavior (spooky action at a distance).

@EECOLOR EECOLOR requested a review from HJSielcken December 28, 2023 22:18
HJSielcken
HJSielcken approved these changes Feb 7, 2024
View reviewed changes
Copy link

@HJSielcken HJSielcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik weet niet of ik ooit de useMatchedRoute heb gebruikt. Maar een iets minder vrije en/of ingewikkelde routing library is volgens mij wel fijn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJSielcken HJSielcken HJSielcken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EECOLOR @HJSielcken