Move build branch to commit 479530dbc PLUS CHERRY PICKS #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he enode is allowed (hyperledger#5584) * Use the node's configuration to decide if adding a peer with DNS in the enode is allowed Signed-off-by: Matthew Whitehead <[email protected]> * Update command test mocks Signed-off-by: Matthew Whitehead <[email protected]> * Update besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> * Address PR comments. Add a reference in the change log. Fix failing integration test. Signed-off-by: Matthew Whitehead <[email protected]> * Add the same DNS-config checking logic to admin_removePeer, along with a unit test file for it Signed-off-by: Matthew Whitehead <[email protected]> * Tweak the change log Signed-off-by: Matthew Whitehead <[email protected]> * Add clearer error messages for the cases where enode DNS is disabled (but a hostname one has been specified in the URL) or where DNS name resolution failed Signed-off-by: Matthew Whitehead <[email protected]> * Spotless Java fixes Signed-off-by: Matthew Whitehead <[email protected]> * Fix copyright for new file Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> * Address PR comments (mainly copyright & constant renaming) Signed-off-by: Matthew Whitehead <[email protected]> * move changelog entry to 23.4.4 Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Matthew Whitehead <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Matthew Whitehead <[email protected]>
…ions Signed-off-by: Fabio Di Fabio <[email protected]>
…er#5669) * Modify the min-gas-price option validation * Check for whether ethash is in use, either from genesis or network config, and use that for miner checks * Add genesis configuration isPoa() convenience function --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Signed-off-by: Simon Dudley <[email protected]>
…he enode is allowed (hyperledger#5584) * Use the node's configuration to decide if adding a peer with DNS in the enode is allowed Signed-off-by: Matthew Whitehead <[email protected]> * Update command test mocks Signed-off-by: Matthew Whitehead <[email protected]> * Update besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> * Address PR comments. Add a reference in the change log. Fix failing integration test. Signed-off-by: Matthew Whitehead <[email protected]> * Add the same DNS-config checking logic to admin_removePeer, along with a unit test file for it Signed-off-by: Matthew Whitehead <[email protected]> * Tweak the change log Signed-off-by: Matthew Whitehead <[email protected]> * Add clearer error messages for the cases where enode DNS is disabled (but a hostname one has been specified in the URL) or where DNS name resolution failed Signed-off-by: Matthew Whitehead <[email protected]> * Spotless Java fixes Signed-off-by: Matthew Whitehead <[email protected]> * Fix copyright for new file Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> * Address PR comments (mainly copyright & constant renaming) Signed-off-by: Matthew Whitehead <[email protected]> * move changelog entry to 23.4.4 Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: Matthew Whitehead <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
* Add lock to creation of pending transaction stream Signed-off-by: Matthew Whitehead <[email protected]> * Alternative synchonization of signalInvalidAndRemoveDependentTransactions Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Matthew Whitehead <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]>
…er#5669) * Modify the min-gas-price option validation * Check for whether ethash is in use, either from genesis or network config, and use that for miner checks * Add genesis configuration isPoa() convenience function --------- Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Matt Whitehead <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Signed-off-by: Simon Dudley <[email protected]>
…nto kaleido-noderunner-dev-cherry-pick-479530dbc Signed-off-by: Chengxuan Xing <[email protected]>
|
besu version built from this branch: |
matthew1001
previously approved these changes
Dec 13, 2023
Chengxuan
changed the title
Chengxuan
dismissed
matthew1001’s stale review
as per discussion, this picks up cherry picks
matthew1001
force-pushed
the
kaleido-noderunner-dev
branch
from
88e68e4 to
479530d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
for https://github.com/kaleido-io/kaleido-planning/issues/2180#issuecomment-1853483285