Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storagenode): remove synchronous Append #970

Open
wants to merge 1 commit into
base: refactor_sn_committer_to_remove_requirecommitwaittasks_parameter
Choose a base branch
from

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Jan 23, 2025

What this PR does

This PR removes the synchronous Append method from Executor, which is unused
code. It also updates tests to use the asynchronous AppendAsync method and
ensures proper handling of AppendTask in tests.

This PR removes the synchronous Append method from Executor, which is unused
code. It also updates tests to use the asynchronous AppendAsync method and
ensures proper handling of AppendTask in tests.
@ijsong ijsong requested a review from hungryjang as a code owner January 23, 2025 12:10
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.02%. Comparing base (b74daea) to head (4f23b35).

Additional details and impacted files
@@                                         Coverage Diff                                          @@
##           refactor_sn_committer_to_remove_requirecommitwaittasks_parameter     #970      +/-   ##
====================================================================================================
- Coverage                                                             80.19%   80.02%   -0.17%     
====================================================================================================
  Files                                                                   178      178              
  Lines                                                                 21500    21432      -68     
====================================================================================================
- Hits                                                                  17241    17151      -90     
- Misses                                                                 3477     3495      +18     
- Partials                                                                782      786       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant