refactor(storagenode): remove unused lines #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor_sn_no_batchlet_in_append #968 +/- ##
=====================================================================
- Coverage 80.06% 80.00% -0.06%
=====================================================================
Files 178 178
Lines 21509 21505 -4
=====================================================================
- Hits 17221 17206 -15
- Misses 3500 3506 +6
- Partials 788 793 +5 ☔ View full report in Codecov by Sentry. |
Removed dead code that was commented out. This improves code readability and maintainability by eliminating dead code.
ijsong
force-pushed
the
refactor_sn_no_batchlet_in_append
branch
from
485f6c6 to
fc7d431
Compare
ijsong
force-pushed
the
remove_deferred_write_batch_code
branch
from
bbcb5b1 to
3e1d1de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Removed dead code that was commented out. This improves code readability and
maintainability by eliminating dead code.