Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storagenode): remove package internal/batchlet #967

Open
wants to merge 1 commit into
base: refactor_logstream_deprecate_old_replicatetask_pool_management
Choose a base branch
from

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Jan 21, 2025

What this PR does

This PR removes the package internal/batchlet that is kind of small batch. Thus
batch in Append RPC message is not splitted any more.

@ijsong ijsong requested a review from hungryjang as a code owner January 21, 2025 12:24
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.06%. Comparing base (daf76e3) to head (fc7d431).

Files with missing lines Patch % Lines
internal/storagenode/logstream/append.go 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                        Coverage Diff                                         @@
##           refactor_logstream_deprecate_old_replicatetask_pool_management     #967      +/-   ##
==================================================================================================
- Coverage                                                           80.09%   80.06%   -0.04%     
==================================================================================================
  Files                                                                 179      178       -1     
  Lines                                                               21592    21509      -83     
==================================================================================================
- Hits                                                                17295    17221      -74     
+ Misses                                                               3502     3500       -2     
+ Partials                                                              795      788       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This PR removes the package internal/batchlet that is kind of small batch. Thus
batch in Append RPC message is not splitted any more.
@ijsong ijsong force-pushed the refactor_sn_no_batchlet_in_append branch from 485f6c6 to fc7d431 Compare January 23, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant