refactor(logstream): deprecate old replicateTask pool management #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## beginllsn_in_replicate #966 +/- ##
==========================================================
+ Coverage 80.02% 80.20% +0.17%
==========================================================
Files 179 179
Lines 21569 21592 +23
==========================================================
+ Hits 17261 17317 +56
+ Misses 3517 3490 -27
+ Partials 791 785 -6 ☔ View full report in Codecov by Sentry. |
hungryjang
reviewed
Feb 1, 2025
hungryjang
approved these changes
Feb 1, 2025
ijsong
force-pushed
the
beginllsn_in_replicate
branch
from
984faf6 to
793fc5e
Compare
ijsong
force-pushed
the
refactor_logstream_deprecate_old_replicatetask_pool_management
branch
from
daf76e3 to
b43dd94
Compare
This PR modifies replicate task pool implementation for future refactoring that will resolve #843. - Deprecated `newReplicateTask` and `release` functions in favor of new implementations. - Added `replicateTaskPool` struct for simplified pool management. - Updated tests to use the new functions and ensure backward compatibility.
ijsong
force-pushed
the
beginllsn_in_replicate
branch
from
793fc5e to
45a6d6b
Compare
ijsong
force-pushed
the
refactor_logstream_deprecate_old_replicatetask_pool_management
branch
from
b43dd94 to
7f3f55b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR modifies replicate task pool implementation for future refactoring that
will resolve #843.
newReplicateTaskandreleasefunctions in favor of newimplementations.
replicateTaskPoolstruct for simplified pool management.