refactor: remove redundant FindLogStream function #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #918 +/- ##
=======================================
Coverage 79.02% 79.02%
=======================================
Files 180 180
Lines 21621 21615 -6
=======================================
- Hits 17085 17081 -4
+ Misses 3719 3713 -6
- Partials 817 821 +4 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
tests_log_stream_uncommit_report
branch
from
099dbf1 to
fe756d5
Compare
ijsong
force-pushed
the
refactor_snmd_getlogstream
branch
from
a0af1e1 to
35530c6
Compare
ijsong
force-pushed
the
tests_log_stream_uncommit_report
branch
from
fe756d5 to
0060a81
Compare
ijsong
force-pushed
the
refactor_snmd_getlogstream
branch
from
35530c6 to
a84aa13
Compare
ijsong
force-pushed
the
tests_log_stream_uncommit_report
branch
from
0060a81 to
ba94afb
Compare
ijsong
force-pushed
the
refactor_snmd_getlogstream
branch
from
a84aa13 to
703a233
Compare
hungryjang
approved these changes
Feb 1, 2025
The FindLogStream function in proto/snpb/metadata.go was removed as it was redundant and no longer needed. The functionality is already covered by the GetLogStream method.
ijsong
force-pushed
the
tests_log_stream_uncommit_report
branch
from
ba94afb to
92511a1
Compare
ijsong
force-pushed
the
refactor_snmd_getlogstream
branch
from
703a233 to
31cc9e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The FindLogStream function in proto/snpb/metadata.go was removed as it was
redundant and no longer needed. The functionality is already covered by the
GetLogStream method.