Check that Handelsbanken accounts are not longer than 9 digits

kajetan-kazimierczak · Aug 15, 2023 · a036e50 · a036e50
1 parent bdf0e61
commit a036e50
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/KajetanKazimierczak.SwedishBankAccounts/BankAccount.cs b/KajetanKazimierczak.SwedishBankAccounts/BankAccount.cs
@@ -194,8 +194,15 @@ private void Validate()
                 {
 
                     var number = _accountNumber;
-                    while (number.Length > 9) number = number.Substring(1);
-                    _isValid = Modulus11.ValidateChecksum(number);
+                    while (number.Length > 9 && number.StartsWith("0")) number = number.Substring(1);
+                    if (number.Length != 9)
+                    {
+                        _isValid = false;
+                        _validationResult = ValidationResult.InvalidAccountNumberLength;
+                        return;
+                    }
+
+                        _isValid = Modulus11.ValidateChecksum(number);
                     _validationResult =
                         _isValid ? ValidationResult.ChecksumValidated : ValidationResult.InvalidChecksum;
                     return;

diff --git a/KajetanKazimierczak.SwedishBankAccounts/KajetanKazimierczak.SwedishBankAccounts.csproj b/KajetanKazimierczak.SwedishBankAccounts/KajetanKazimierczak.SwedishBankAccounts.csproj
@@ -10,13 +10,12 @@
     <Copyright>Kajetan Kazimierczak</Copyright>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <PackageTags>swedish bank account validator validate bankkonto bankgiro plusgiro</PackageTags>
-    <Version>1.0.13</Version>
+    <Version>1.0.14</Version>
     <Description>Can validate most swedish bank account numbers consisting of clearing number and account number. Also validates BankGiro and PlusGiro account numbers.</Description>
     <RepositoryUrl>https://github.com/kajetan-kazimierczak/SwedishBankAccounts</RepositoryUrl>
     <PackageLicenseUrl></PackageLicenseUrl>
     <PackageReleaseNotes>
-      Update to document version 2023-02-21
-      Added .NET 7 version
+      Buggfix: Sometimes incorrectly reported Handelsbanken accounts as valid.
     </PackageReleaseNotes>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
     <PackageProjectUrl>https://github.com/kajetan-kazimierczak/SwedishBankAccounts</PackageProjectUrl>