This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
experiment manager 重构 #801
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 19, 2020
juniwang
reviewed
Apr 19, 2020
| try: | ||
| api_instance = client.CoreV1Api(self.api_client) | ||
| api_instance.list_namespaced_pod(self.namespace, timeout_seconds=timeout) | ||
| return {HEALTH.STATUS: HEALTH_STATUS.OK} |
juniwang
reviewed
Apr 19, 2020
| except HTTPError: | ||
| return { | ||
| HEALTH.STATUS: HEALTH_STATUS.ERROR, | ||
| HEALTH.DESCRIPTION: "Connect K8s ApiServer {} error: connection timeout".format(self.api_url), |
juniwang
reviewed
Apr 19, 2020
| celery_app.conf.update( | ||
| CELERY_BROKER_URL=safe_get_config("CELERY_BROKER_URL", ""), | ||
| CELERY_RESULT_BACKEND=safe_get_config("CELERY_RESULT_BACKEND", ""), | ||
| CELERY_DEFAULT_EXCHANGE='oph', |
juniwang
approved these changes
May 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
重构环境分配的逻辑，并顺便解决历史遗留 issue