Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: RAG pipeline leaking cluster patch #875

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bangqipropel
Copy link
Collaborator

@bangqipropel bangqipropel commented Feb 11, 2025

Reason for Change:

  1. Use composite steps for avoiding cleaning step is not run when interrupted.
  2. Add RAG pipeline back when rag engine related codes are changed.
  3. Use the image aimodelsregistrytest.azurecr.io/kaito-rag-service:0.0.7 for now, will change it back when MCR image is good
  4. Changed the image in the unit test too

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@bangqipropel bangqipropel force-pushed the bangqipropel/RAG_pipeline_fix branch from 2f944b1 to 6865c84 Compare February 11, 2025 07:27
@bangqipropel bangqipropel force-pushed the bangqipropel/RAG_pipeline_fix branch 2 times, most recently from 9b7195d to 6358da2 Compare February 11, 2025 10:05
@bangqipropel bangqipropel force-pushed the bangqipropel/RAG_pipeline_fix branch from 6358da2 to 2559082 Compare February 11, 2025 10:12
@bangqipropel bangqipropel force-pushed the bangqipropel/RAG_pipeline_fix branch from 2559082 to aa01a67 Compare February 11, 2025 10:19
@bangqipropel bangqipropel force-pushed the bangqipropel/RAG_pipeline_fix branch from aa01a67 to 2aabbba Compare February 11, 2025 10:27
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
pkg/ragengine/controllers/preset-rag.go 70.73% <100.00%> (ø)

... and 18 files with indirect coverage changes

Bangqi Zhu added 2 commits February 13, 2025 10:17
Signed-off-by: Bangqi Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant