Don't write an empty k3s service on disk

[jimmykarily]

just use the one that was created by the k3s installer script

Fixes: kairos-io/kairos#2125

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (874beb3) 7.93% compared to head (096d0ef) 8.11%.

Files	Patch %	Lines
internal/provider/bootstrap.go	0.00%	5 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##            main    #519      +/-   ##
========================================
+ Coverage   7.93%   8.11%   +0.17%     
========================================
  Files         15      15              
  Lines        958     937      -21     
========================================
  Hits          76      76              
+ Misses       866     845      -21     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mudler]

this likely will break alpine - in the original openrc service file there is no way to override environment variables (which are actually used to set K3S_*)

[mauromorales]

we are not over-writing the init file any longer since we remove the WriteService line. So the original installation unit will be present and reading from the env location

[mudler]

yep right, what I'm saying is that we used to write to a custom location, the env file is not read by the original k3s unit, it is kairos-specific (at least at the time of writing the provider)

[mauromorales]

@mudler gotcha, let me validate alpine then, meanwhile, I decided to merge because at least is better to have systemd systems working even if OpenRC ones (alpine) would break

[jimmykarily]

We built an image with this for fedora and it works.

[mudler]

We built an image with this for fedora and it works.

did you tried with a master/agent or just single-node? #519 (comment) would probably get unnoticed until you try specifically to customize how you start k3s or k3s-agent

[mauromorales]

@mudler validated it and it's working correctly on alpine too. This is because the installer from k3s creates a unit file which ends with:

if [ -f /etc/environment ]; then . /etc/environment; fi
if [ -f /etc/rancher/k3s/k3s-agent.env ]; then . /etc/rancher/k3s/k3s-agent.env; fi

and we write to /etc/rancher/k3s/k3s-agent.env the following:

K3S_TOKEN="..."
K3S_URL="https://192.168.122.18:6443"
command_args="agent --with-node-id >>/var/log/k3s-agent.log 2>&1"