Skip artifacts that don't have proper names #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing kairos-io/kairos#3167 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
commented
Feb 4, 2025
| if len(versions) < 1 { | ||
| // skip badly named artifacts that may not have a software version | ||
| // https://github.com/kairos-io/kairos/issues/3167#issuecomment-2633282993 | ||
| if len(versions) < 2 { |
There was a problem hiding this comment.
some lines below, we assume there is versions[1] leading to:
panic: runtime error: index out of range [1] with length 1
when that's not the case.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
==========================================
+ Coverage 52.50% 52.55% +0.04%
==========================================
Files 19 19
Lines 1996 1998 +2
==========================================
+ Hits 1048 1050 +2
Misses 818 818
Partials 130 130 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
commented
Feb 4, 2025
| @@ -133,6 +133,7 @@ | |||
| "sha256-5cc0764ac2e7893fbb1246967dcef6d53736fcc86c1c436b976c3aab26824368.sig", | |||
| "tumbleweed-core-arm64-rpi4-v2.4.2-rc1-img", | |||
| "leap-15.5-standard-amd64-generic-v2.4.2-rc1-k3sv1.26.9-k3s1", | |||
| "leap-15.5-standard-amd64-generic-v2.4.2-rc1", | |||
There was a problem hiding this comment.
this fails without the fix below
mauromorales
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing kairos-io/kairos#3167