Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GetImage platform handling #557

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve GetImage platform handling #557

wants to merge 3 commits into from

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Jan 16, 2025

local daemon is not able to pull multiple arch images nor you can ask it to give you an image and a platform. So if the local daemon has image X for platform amd64 and you wanted it for arm64 it would return that wrong platform image.

This commit checks if the platform is the proper one and if not falls back into asking the remote for the proper platform image

local daemon is not able to pull multiple arch images nor you can ask it
to give you an image and a platform. So if the local daemon has image X
for platform amd64 and you wanted it for arm64 it would return that
wrong platform image.

This commit checks if the platform is the proper one and if not falls
back into asking the remote for the proper platform image

Signed-off-by: Itxaka <[email protected]>
@Itxaka Itxaka requested a review from a team January 16, 2025 10:15
Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noiiiice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants