Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BCSS dataset #559

Merged
merged 20 commits into from
Jul 16, 2024
Merged

Add BCSS dataset #559

merged 20 commits into from
Jul 16, 2024

Conversation

nkaenzig
Copy link
Collaborator

@nkaenzig nkaenzig commented Jul 9, 2024

Closes #553

After 4 epochs using ImageNet pre-trained vit_small_patch16_224_dino encoder:
image

@nkaenzig nkaenzig linked an issue Jul 9, 2024 that may be closed by this pull request
Add BCSS segmentation dataset #553
Closed
@nkaenzig nkaenzig marked this pull request as ready for review July 9, 2024 12:11
@nkaenzig nkaenzig requested review from roman807 and ioangatop July 9, 2024 12:11
@nkaenzig nkaenzig self-assigned this Jul 9, 2024
ioangatop
ioangatop reviewed Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@ioangatop ioangatop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, cool that we mix some minor staff as well - the only think that I have to ask of course if for the split, thoughts?

src/eva/vision/data/datasets/segmentation/bcss.py Outdated Show resolved Hide resolved
src/eva/vision/data/datasets/segmentation/bcss.py Outdated Show resolved Hide resolved
@nkaenzig nkaenzig requested a review from ioangatop July 12, 2024 07:21
roman807
roman807 reviewed Jul 12, 2024
View reviewed changes
docs/datasets/bcss.md Outdated Show resolved Hide resolved
ioangatop
ioangatop reviewed Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@ioangatop ioangatop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! here couple of comments, I think we will merge it super soon

src/eva/vision/data/datasets/segmentation/consep.py Outdated Show resolved Hide resolved
src/eva/vision/data/datasets/segmentation/bcss.py Outdated Show resolved Hide resolved
src/eva/vision/data/datasets/segmentation/bcss.py Outdated Show resolved Hide resolved
src/eva/vision/data/datasets/segmentation/bcss.py Show resolved Hide resolved
src/eva/vision/data/datasets/segmentation/bcss.py Show resolved Hide resolved
src/eva/vision/data/datasets/segmentation/bcss.py Show resolved Hide resolved
@nkaenzig nkaenzig mentioned this pull request Jul 16, 2024
Open
@nkaenzig nkaenzig merged commit e7920e5 into main Jul 16, 2024
6 checks passed
@nkaenzig nkaenzig deleted the 553-add-bcss-segmentation-dataset branch July 16, 2024 07:41
@nkaenzig nkaenzig mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman807 roman807 roman807 left review comments

@ioangatop ioangatop ioangatop approved these changes

Assignees

@nkaenzig nkaenzig

Labels
dataset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add BCSS segmentation dataset
3 participants
@nkaenzig @roman807 @ioangatop