Add async loading

[coderdan]

No description provided.

[johndagostino]

Hey @madrabbit would be really good to get these changes merged in or if you had any feedback. // @coderdan @jehanzebkhan

[kaievns]

Sorry guys, i don't think those changes fit the idea of this little gem

1. The '.empty' thing you jacked into the .locker doesn't belong in there, coz it supposed to be rendered by the server
2. if you want to support the async option it should be a part of the options, not an extra symbolic thingy
3. Mixing the javascript part with jQuery also doesn't make any sense, i was explicitly trying to avoid it and operate just with the $ function so it could be easily replaced with a similar object

[coderdan]

I can't speak to the first comment @jehanzebkhan may be able to comment there.

I'm not sure I follow what you mean with comments 2 and 3. Can you suggest how we might be able to do the async function? It is being passed as an option now to the helper. Which options are you referring to when you say it should be part of the options?

With regards to the 3rd comment, are you referring to the use of $(document).ready(function(). Do you have a suggestion as to how you'd like to see this done?

Thanks for your help.

[bloopletech]

Chipping in because some of these changes are my fault :)

I think you have some really good points, so we're going to go back and see what we can do to clean things up while still fulfilling all our requirements.

[kaievns]

@coderdan @bloopletech hey guys just to clarify

2. i meant this def osom_table_for(*args, &block), i'd prefer it stay as it was def bosom_table_for(items, options={}, &block)

3. i referred to the $.fn.osom_table, i want the javascript part to be tied to jQ as little as possible

[coderdan]

OK thanks, Nik. We'll make some changes and redo.

On Tue, Mar 4, 2014 at 9:48 AM, Nikolay Nemshilov
[email protected]:

@coderdan https://github.com/coderdan @bloopletechhttps://github.com/bloopletechhey guys just to clarify

2. i meant this def osom_table_for(*args, &block), i'd prefer it stay as
   it was def bosom_table_for(items, options={}, &block)

3. i referred to the $.fn.osom_table, i want the javascript part to be
   tied to jQ as little as possible

Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-36570835
.

Dan Draper
CEO and Co-founder
www.codehire.comhttp://www.codehire.com/?utm_source=emailsig&utm_medium=email&utm_campaign=email

Twitter: @danieldraper
Skype: danieldraper100
Mobile: +61403089661
LinkedIn: http://www.linkedin.com/in/ddraper