Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add icons to menus #157

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

The-Compiler
Copy link
Contributor

I like icons in my menus and I cannot lie - after adding some ~600 icons to VSpaceCode, I took a look at edamagit next.

A few examples on how this looks with my config:

image
image
image
image
image

(Yay, giant screenshots again - I always forgot that I'm on a 4k screen and zoom in way too much)

Before I continue with this and try to find more icons, I thought I'd get some feedback - what do you think? Does this sound reasonable? Should this be an option or just hardcoded like now?

I guess sometimes it can be hard to find matching icons, and I haven't looked at most of the commented out commands yet. Often, however, it's surprisingly possible to find something in the giant list of icons with some creativity.

@kahole
Copy link
Owner

kahole commented Jul 14, 2021

Icons look good I think. Fits in with the philosophy of "magit, but in a way that fits in the ecosystem and plays on the strengths of vscode".
Maybe we can start by having it be a feature toggle in the config, like "Forge" is.

@The-Compiler
Copy link
Contributor Author

Thanks for the feedback! I plan to pick this up again in around 3-4 weeks.

@black7375 black7375 mentioned this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants