Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Support armadillo #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Support armadillo #5

wants to merge 2 commits into from

Conversation

kafku
Copy link
Owner

@kafku kafku commented Dec 31, 2019 •
edited
Loading

typot[bot]
typot bot reviewed Dec 31, 2019
View reviewed changes
Copy link

@typot typot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review from typot

README.md
@@ -5,6 +5,7 @@
- [ArrayFire](https://github.com/arrayfire/arrayfire)
- [x] `af::array`
- [x] `af::dim4`
- [Armadillo](http://arma.sourceforge.net)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Armadillo" at 8 is typo?

README.md
@@ -5,6 +5,7 @@
- [ArrayFire](https://github.com/arrayfire/arrayfire)
- [x] `af::array`
- [x] `af::dim4`
- [Armadillo](http://arma.sourceforge.net)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"-" at 8 is typo?

  • e
  • s
  • i
  • a
  • n

@kafku kafku added the enhancement New feature or request label Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typot typot[bot] typot[bot] left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kafku