Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: FE: migrate to node 22 #748

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Infra: FE: migrate to node 22 #748

merged 3 commits into from
Jan 14, 2025

Conversation

yeikel
Copy link
Collaborator

@yeikel yeikel commented Jan 3, 2025

What changes did you make? (Give an overview)

Node 18 reached end of life in 18 Oct 2023. The latest LTS version of Node is 22.x

See https://endoflife.date/nodejs

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings (e.g. Sonar is happy)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

A picture of a cute animal (not mandatory but encouraged)

cute-wild-animals-photos-hardcore-aww-2-63345025740e4__700

@yeikel yeikel requested review from a team as code owners January 3, 2025 20:51
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jan 3, 2025
frontend/package.json Outdated Show resolved Hide resolved
@Haarolean Haarolean added scope/frontend Related to frontend changes type/dependencies A pull request/issue dedicated to updating the dependency(-ies) and removed status/triage/manual Manual triage in progress labels Jan 8, 2025
@yeikel
Copy link
Collaborator Author

yeikel commented Jan 9, 2025

@Haarolean Can you approve the other workflows?

@Haarolean
Copy link
Member

@Haarolean Can you approve the other workflows?

not sure that's needed since we're adjusting a workflow here and it won't run until merged, so we can't test this thing before merging anyway, unless run on a fork.

@Haarolean Haarolean added this to the 1.2 milestone Jan 14, 2025
@Haarolean Haarolean merged commit aaac4d7 into kafbat:main Jan 14, 2025
13 of 15 checks passed
@Haarolean
Copy link
Member

@yeikel thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend Related to frontend changes scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/dependencies A pull request/issue dedicated to updating the dependency(-ies)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants