Infra: Run cve checks workflow on pull requests and pushes to main #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapybro
bot
added
status/triage
2 tasks
|
@Haarolean I noticed that you implemented this recently: #219 We probably do not want to send notifications for every failure (definitely not from pull requests). Do you have any suggestion about when should it be sent? For now, I pushed d5a52d3 to only send it from |
Haarolean
requested changes
Jan 4, 2025
| @@ -1,5 +1,8 @@ | |||
| name: "Infra: CVE checks" | |||
| on: | |||
| pull_request_target: | |||
There was a problem hiding this comment.
I think we don't need pull_request_target for this particular workflow, pull_request should suffice.
| @@ -71,7 +74,7 @@ jobs: | |||
|
|
|||
| notify: | |||
| needs: build-and-test | |||
| if: ${{ always() && needs.build-and-test.result == 'failure' }} | |||
| if: ${{ always() && needs.build-and-test.result == 'failure' && github.ref == 'refs/heads/main' }} | |||
There was a problem hiding this comment.
Could you please adjust this so it only runs upon failures of scheduled runs?
Thank you for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Closes #707
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Tested here :
main: https://github.com/yeikel/kafka-ui/actions/runs/12602983150/job/35127088622Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
A picture of a cute animal (not mandatory but encouraged)