Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBAC: Make it possible to use regex for values #663

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

RBAC: Make it possible to use regex for values #663

wants to merge 7 commits into from

Conversation

francoisvandenplas
Copy link

@francoisvandenplas francoisvandenplas commented Nov 19, 2024 •
edited by Haarolean
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Rbac now handle regex in values
Fixes #300

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@francoisvandenplas francoisvandenplas requested a review from a team as a code owner November 19, 2024 10:36
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress area/rbac Related to Role Based Access Control feature status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Nov 19, 2024
@callaertanthony
Copy link

Hey ! Any chance to see this PR merged ?

@Haarolean
Copy link
Member

Haarolean commented Jan 14, 2025 •
edited
Loading

Hey ! Any chance to see this PR merged ?

sorry, will take a look this week

@Haarolean Haarolean added this to the 1.2 milestone Jan 14, 2025
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes and removed status/triage/manual Manual triage in progress labels Jan 14, 2025
@Haarolean Haarolean changed the title Issues/300 regex for rbac RBAC: Make it possible to use regex for values Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/rbac Related to Role Based Access Control feature scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
Release 1.2
Status: Todo
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

RBAC: Make it possible to use regex for values
3 participants
@francoisvandenplas @callaertanthony @Haarolean