-
-
Notifications
You must be signed in to change notification settings - Fork 135
BE: Auth: Support GCP IAM Auth #1013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
BE: Auth: Support GCP IAM Auth #1013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Muchembi! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Can we also get a test like AzureEntraLoginCallbackHandlerTest
but for GCP? Feel free to mock it heavily.
@Muchembi also, could you please update our docs to reflect new changes? |
What changes did you make? (Give an overview)
resolves #1012
Is there anything you'd like reviewers to focus on?
The front end especially.
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
