Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring revisionHistoryLimit #24

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

nbarrientos
Copy link
Contributor

No description provided.

@nbarrientos nbarrientos requested a review from a team as a code owner September 16, 2024 14:21
@azatsafin
Copy link
Member

_ No description provided. _

It will nice if you provide some scenario why you need this change.
Please add the default value for .Values.revisionHistoryLimit in the values.conf.
Please upgrade minor version of helm chart.

@nbarrientos
Copy link
Contributor Author

Hi @azatsafin

Thanks for taking a look!

I believe that it's useful to be able to limit the number of residual replicasets to retain. Kubernetes' default (10) might be too much once you have reached an acceptable level of maturity/stability when rarely several roll backs are necessary.

I didn't add a default in this chart's values as I thought it'd be a good idea to rely on Kubernetes' default solely but I can replicate it here if you'd like. Users might expect the chart to rely on Kubernetes' default if not specified -- I'd do, personally.

Thanks!

@nbarrientos
Copy link
Contributor Author

Please upgrade minor version of helm chart.

Done. Assuming semver.

sorry, it should be patch version
just want to let users know that it exists
Copy link
Member

@azatsafin azatsafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azatsafin azatsafin merged commit 16831e5 into kafbat:main Sep 17, 2024
1 check passed
@nbarrientos nbarrientos deleted the ib_rhl branch September 17, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants