lxc/completion: Pre-allocate slices where possible

Signed-off-by: Kadin Sayani <[email protected]>

lxc/completion.go

@@ -41,7 +41,6 @@ func (g *cmdGlobal) cmpClusterGroupNames(toComplete string) ([]string, cobra.She
 // cmpClusterGroups provides shell completion for cluster groups and their remotes.
 // It takes a partial input string and returns a list of matching cluster groups along with a shell completion directive.
 func (g *cmdGlobal) cmpClusterGroups(toComplete string) ([]string, cobra.ShellCompDirective) {
-	var results []string
 	cmpDirectives := cobra.ShellCompDirectiveNoFileComp
 
 	resources, _ := g.ParseServers(toComplete)
@@ -62,6 +61,8 @@ func (g *cmdGlobal) cmpClusterGroups(toComplete string) ([]string, cobra.ShellCo
 		return nil, cobra.ShellCompDirectiveError
 	}
 
+	results := make([]string, 0, len(groups))
+
 	for _, group := range groups {
 		var name string
 
@@ -105,7 +106,7 @@ func (g *cmdGlobal) cmpClusterMemberConfigs(memberName string) ([]string, cobra.
 		return nil, cobra.ShellCompDirectiveError
 	}
 
-	var results []string
+	results := make([]string, 0, len(member.Config))
 	for k := range member.Config {
 		results = append(results, k)
 	}
@@ -510,7 +511,7 @@ func (g *cmdGlobal) cmpInstanceDeviceNames(instanceName string) ([]string, cobra
 		return nil, cobra.ShellCompDirectiveError
 	}
 
-	var results []string
+	results := make([]string, 0, len(instanceNameOnly.Devices))
 	for k := range instanceNameOnly.Devices {
 		results = append(results, k)
 	}
@@ -754,7 +755,7 @@ func (g *cmdGlobal) cmpNetworkACLConfigs(aclName string) ([]string, cobra.ShellC
 		return nil, cobra.ShellCompDirectiveError
 	}
 
-	var results []string
+	results := make([]string, 0, len(acl.Config))
 	for k := range acl.Config {
 		results = append(results, k)
 	}
@@ -765,7 +766,6 @@ func (g *cmdGlobal) cmpNetworkACLConfigs(aclName string) ([]string, cobra.ShellC
 // cmpNetworkACLs provides shell completion for network ACL's.
 // It takes a partial input string and returns a list of matching network ACL's along with a shell completion directive.
 func (g *cmdGlobal) cmpNetworkACLs(toComplete string) ([]string, cobra.ShellCompDirective) {
-	var results []string
 	cmpDirectives := cobra.ShellCompDirectiveNoFileComp
 
 	resources, _ := g.ParseServers(toComplete)
@@ -781,6 +781,7 @@ func (g *cmdGlobal) cmpNetworkACLs(toComplete string) ([]string, cobra.ShellComp
 		return nil, cobra.ShellCompDirectiveError
 	}
 
+	results := make([]string, 0, len(acls))
 	for _, acl := range acls {
 		var name string
 
@@ -832,7 +833,7 @@ func (g *cmdGlobal) cmpNetworkForwardConfigs(networkName string, listenAddress s
 		return nil, cobra.ShellCompDirectiveError
 	}
 
-	var results []string
+	results := make([]string, 0, len(forward.Config))
 	for k := range forward.Config {
 		results = append(results, k)
 	}
@@ -1182,7 +1183,7 @@ func (g *cmdGlobal) cmpProfileConfigs(profileName string) ([]string, cobra.Shell
 		return nil, cobra.ShellCompDirectiveError
 	}
 
-	var configs []string
+	configs := make([]string, 0, len(profile.Config))
 	for c := range profile.Config {
 		configs = append(configs, c)
 	}
@@ -1283,7 +1284,7 @@ func (g *cmdGlobal) cmpProjectConfigs(projectName string) ([]string, cobra.Shell
 		return nil, cobra.ShellCompDirectiveError
 	}
 
-	var configs []string
+	configs := make([]string, 0, len(project.Config))
 	for c := range project.Config {
 		configs = append(configs, c)
 	}