New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept negative numbers in str-to-int #1086

Draft

imalsogreg wants to merge 3 commits into master from gregh/gh-1049/str-to-int-negative

Contributor

imalsogreg commented Dec 5, 2022 •

edited by rsoeldner

Loading

Fixes #1049

Make str-to-int work for negative numbers (except for base64)
Make int-to-str work for negative numbers
Fix str to int implementation in FV
Put the new behavior behind a flag
Fix tests

imalsogreg added 3 commits

December 2, 2022 19:26


          Accept negative numbers in str-to-int

83b81ae


          drop flake.nix

04fafb5


          Add checks for non-digit characers

029f09b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jwiegley Awaiting requested review from jwiegley jwiegley will be requested when the pull request is marked ready for review jwiegley is a code owner

emilypi Awaiting requested review from emilypi emilypi will be requested when the pull request is marked ready for review emilypi is a code owner

jmcardon Awaiting requested review from jmcardon jmcardon will be requested when the pull request is marked ready for review jmcardon is a code owner

At least 2 approving reviews are required to merge this pull request.

Labels

None yet