Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop exporting constructors for BlockHeader and PayloadData #1977

Conversation

chessai
Copy link
Contributor

@chessai chessai commented Jul 1, 2024

Change-Id: Id6200af01359d9012ea532a485ac25d2ab36d0c5

@chessai chessai marked this pull request as draft July 1, 2024 22:27
@chessai chessai force-pushed the chessai/stop-exporting-constructors-for-blockheader-and-payloaddata branch 4 times, most recently from 80a9092 to 7d60b63 Compare July 2, 2024 15:02
@chessai chessai marked this pull request as ready for review July 16, 2024 18:52
@chessai chessai changed the title stop exporting BlockHeader constructor from Chainweb.BlockHeader stop exporting constructors for BlockHeader and PayloadData Jul 16, 2024
@chessai chessai force-pushed the chessai/stop-exporting-constructors-for-blockheader-and-payloaddata branch from 7d60b63 to 54c1949 Compare July 16, 2024 20:22
chessai and others added 2 commits July 16, 2024 16:48
Co-authored-by: Emmanuel Denloye-Ito <[email protected]>
Change-Id: Id6200af01359d9012ea532a485ac25d2ab36d0c5
Co-authored-by: Emmanuel Denloye-Ito <[email protected]>
Change-Id: I5d50e6a283dfebb630e4cea84bcb8598117e4c89
@chessai chessai force-pushed the chessai/stop-exporting-constructors-for-blockheader-and-payloaddata branch from 54c1949 to b642b07 Compare July 16, 2024 21:48
@chessai chessai added this pull request to the merge queue Jul 17, 2024
Merged via the queue into master with commit efd1243 Jul 17, 2024
20 of 21 checks passed
@chessai chessai deleted the chessai/stop-exporting-constructors-for-blockheader-and-payloaddata branch July 17, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants