Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosetta Tests #1079

Merged
merged 68 commits into from
Jul 9, 2020
Merged

Rosetta Tests #1079

merged 68 commits into from
Jul 9, 2020

Conversation

emilypi
Copy link
Member

@emilypi emilypi commented Jun 15, 2020

Implements the associated Rosetta API information, standalone clients, test scaffolding, and tests.

  • Account balance endpoint tests - 100%
  • Block transaction endpoint tests - 100%
  • Block endpoint tests - 100%
  • Construction submit endpoint tests - 100%
    [ ] Construction Metadata endpoint tests - Unsupported
    [ ] Mempool tx endpoint tests - 60% Unsupported: mempool latencies may be too low in the mempool to accurately catch this.
  • Mempool endpoint tests - 100%
  • Network list endpoint tests - 100%
  • Network options endpoint tests - 100%
  • Network status endpoint tests. - 100%

@LindaOrtega
Copy link
Contributor

for when its done:
Fixes #1073

src/Chainweb/Version.hs Outdated Show resolved Hide resolved
src/Chainweb/Version.hs Outdated Show resolved Hide resolved
Copy link
Contributor

@LindaOrtega LindaOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I added some suggestions for the /network/options tests for added correctness.

test/Chainweb/Test/Utils.hs Show resolved Hide resolved
test/Chainweb/Test/Rosetta/RestAPI.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Rosetta/RestAPI.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Rosetta/RestAPI.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Rosetta/RestAPI.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Rosetta/RestAPI.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/Rosetta/RestAPI.hs Show resolved Hide resolved
test/Chainweb/Test/Rosetta/RestAPI.hs Show resolved Hide resolved
@emilypi emilypi merged commit 518a3d2 into master Jul 9, 2020
@emilypi emilypi deleted the rosetta-tests branch July 9, 2020 20:55
@larskuhtz larskuhtz mentioned this pull request Aug 2, 2020
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants