-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@kadena/graph-client] Added query information on each page #1394
Conversation
MRVDH
commented
Dec 27, 2023
•
edited
Loading
edited
🦋 Changeset detectedLatest commit: 6081855 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
{() => ( | ||
<DialogContent> | ||
<p>Query</p> | ||
{queries.map((query, index) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's more than one query with variables, does it still make sense to represent them in the same <DialogContent>
? My concern is only if the variables happen to have the same name, it can be confusing to determine which one belongs to which.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ry-info-on-every-page
Makes more sense indeed. Moved to the right! |