Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the namespace tutorial in the election app workshop series. #1378

Merged
merged 8 commits into from
Jan 12, 2024

Conversation

lsgunnlsgunn
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Dec 20, 2023

🦋 Changeset detected

Latest commit: 0dd74ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
alpha-docs ✅ Ready (Inspect) Visit Preview Dec 28, 2023 11:24pm
docs-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 11:24pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
proof-of-us ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 11:24pm
react-ui ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 11:24pm
tools ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 11:24pm

Copy link
Member

@alber70g alber70g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

.vscode/settings.json Outdated Show resolved Hide resolved
"*.json": "jsonc"
},
"graphql-config.load.rootDir": "packages/apps/graph"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure this file should be deleted. @alber70g , I was under the impression it was needed?

@lsgunnlsgunn lsgunnlsgunn merged commit 1e5e76d into main Jan 12, 2024
8 checks passed
@lsgunnlsgunn lsgunnlsgunn deleted the LG/namespace-election-5 branch January 12, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants