Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Artifact release to also publish HCD 1.2 Agent #591

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

emerkle826
Copy link
Contributor

@emerkle826 emerkle826 commented Jan 17, 2025

@emerkle826 emerkle826 force-pushed the publish-hcd-1.2-artifacts branch 2 times, most recently from 5fdd1a0 to 9d01c3e Compare January 17, 2025 22:35
* Combine release jobs into single workflow file
* Refactor Integration tests into its own submodule.
  Refactor Dockerfiles so building an image does not
  have to rebuild the artifacts within the Docker
  image build process
* Update Docker release to use release version artifacts
@emerkle826 emerkle826 force-pushed the publish-hcd-1.2-artifacts branch from 9d01c3e to 8748e0a Compare January 17, 2025 23:39
@emerkle826
Copy link
Contributor Author

@burmanm I would appreciate a review of this if you have some time.

@burmanm
Copy link
Contributor

burmanm commented Jan 18, 2025

I assume the main benefit is faster CI when we don't need to compile mgmt-api for every version all the time?

@emerkle826
Copy link
Contributor Author

I assume the main benefit is faster CI when we don't need to compile mgmt-api for every version all the time?

Yes, but really it's an attempt to get more reliable Docker image builds. Lately, when we do a release, I've had to re-run some of the Docker builds multiple times because each of the 118 images will also run a Maven build. Eventually a handful of them will fail because of some issue pulling artifacts from our Maven Artifactory.

With these changes, we build the branch/tag once and cache the build artifacts so the follow-on jobs can just restore and then build images by just copying the artifacts in.

Another approach I considered was going back to a "base" image that just builds the artifacts, and then pushing that image to a local repo that all the real image builds could simply pull from. I could still do that, if you think that would be a better approach.

@burmanm
Copy link
Contributor

burmanm commented Jan 20, 2025

I could still do that, if you think that would be a better approach.

No, this is fine, we get the built files in the action artifacts, easier to debug if something went wrong.

@emerkle826 emerkle826 merged commit 621fc8e into master Jan 20, 2025
109 checks passed
@emerkle826 emerkle826 deleted the publish-hcd-1.2-artifacts branch January 20, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Artifact release to also publish HCD 1.2 Agent Optimize Docker image releases
2 participants